Let's check errors a little better.

DataDog / kvexpress

## Auto-archived due to inactivity. ## Go program to move data in and out of Consul's KV store.

Apache License 2.0

129 stars 13 forks source link

Let's check errors a little better. #94

Closed darron closed 8 years ago

darron commented 8 years ago

Pursuant to issue #93 - here's the beginning of a PR to rid the code base of the scourge of ", _".

After this is merged we'll add errcheck and a few other automatic tests to the Wercker CI build

darron commented 8 years ago

I will be testing this branch in staging next week.

darron commented 8 years ago

Testing in staging now - it functions for the most part - found this regression:

diff-error

darron commented 8 years ago

2d627374944aaf4e70b88a99345ecbf5c3546dc3 fixed the diff problem.

Tried a few different things to test the exec.Command better but didn't have much success so I reverted for the time being.

darron commented 8 years ago

Running this test version in staging:

[staging]darron@i-1dc56ea3:~/kvexpress$ sudo /usr/local/bin/kvexpress -v
Version  : 1.13-dev
Revision : 2d627374944aaf4e70b88a99345ecbf5c3546dc3
Date     : 20160503.210533
Go       : go1.6.1

darron commented 8 years ago

Everything worked great in staging - merged and closed.