Does not handle missing files well

DataDog / kvexpress

## Auto-archived due to inactivity. ## Go program to move data in and out of Consul's KV store.

Apache License 2.0

128 stars 13 forks source link

Does not handle missing files well #98

Open calebdoxsey opened 7 years ago

calebdoxsey commented 7 years ago

We setup KVExpress to pull down a file which didn't exist yet, and it caused a slow leak of file descriptors and error messages. Eventually the machine hit the limit, then spewed GB of data into logs and caused all kinds of bizarre problems.

We should test KVExpress with files that don't exist and make sure it doesn't leak file descriptors, implements some sort of exponential backoff, etc...

darron commented 7 years ago

When you say files - you're referring to a key in the KV store right?

I saw this problem once before - but didn't go into duplicating it. It's possibly related to some of the Consul connection logic - it's likely I'm not closing the connection and that's leaving it in some sort of intermediate state.