Closed bwoebi closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.82%. Comparing base (
7224cd1
) to head (1a7d347
).
Benchmark execution time: 2024-10-22 16:16:04
Comparing candidate commit 1a7d347 in PR branch bob/sidecar-proc-fd
with baseline commit 7224cd1 in branch main
.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.
Omitted due to size.
It worked when DD_SPAWN_WORKER_USE_EXEC=1 was set, but not generally. Having a /proc//X path will tell gdb exactly where to find it, instead of a /proc/self/fd/X which is pointing into gdbs own process from the perspective of gdb.
This also prevented sidecar core dumps from being opened with gdb, which was rather ugly.
(Also updates the Cargo.toml of trace-utils to include the required hyper runtime, otherwise the server feature will fail to compile...)