DataDog / libdatadog

Datadog shared rust-based library. For now only used in other products (e.g. Ruby or PHP libraries).
Apache License 2.0
47 stars 8 forks source link

Increase DogStatsD Buffer Size and Pattern Match Container Ids #698

Closed duncanpharvey closed 4 days ago

duncanpharvey commented 5 days ago

What does this PR do?

Fixes two issues that prevent DogStatsD metrics from being submitted in some environments.

In addition, lazily initialize static regex for dogstatsd metrics.

Motivation

https://datadoghq.atlassian.net/browse/SVLS-5799

Additional Notes

Some DogStatsD messages in Azure Spring App environments were larger than 1KB, causing them to be truncated. These messages also include container ids with the pattern c:*.

DogStatsD protocol v1.2

DEBUG Received message: datadog.dogstatsd.client.metrics:0|c|#env:dev,service:azure-spring-app,client:java,client_version:4.4.2,client_transport:udp|c:b9ee8edd7d87cbbcf378f30f8d303dd71e8899006fb4ea6369a774b1e5dd0fb3
datadog.dogstatsd.client.events:0|c|#env:dev,service:azure-spring-app,client:java,client_version:4.4.2,client_transport:udp|c:b9ee8edd7d87cbbcf378f30f8d303dd71e8899006fb4ea6369a774b1e5dd0fb3
datadog.dogstatsd.client.service_checks:0|c|#env:dev,service:azure-spring-app,client:java,client_version:4.4.2,client_transport:udp|c:b9ee8edd7d87cbbcf378f30f8d303dd71e8899006fb4ea6369a774b1e5dd0fb3
datadog.dogstatsd.client.bytes_sent:3576|c|#env:dev,service:azure-spring-app,client:java,client_version:4.4.2,client_transport:udp|c:b9ee8edd7d87cbbcf378f30f8d303dd71e8899006fb4ea6369a774b1e5dd0fb3
datadog.dogstatsd.client.bytes_dropped:0|c|#env:dev,service:azure-spring-app,client:java,client_version:4.4.2,client_transport:udp|c:b9ee8edd7d87cbbcf378f30f8d303dd71e8899006fb4ea6369a774b1e5dd0fb3
datadog.dogstatsd.client.packets_sent:3|c|#env from 127.0.0.1:33589

The max buffer size value of 8192 bytes is used to match the default value used in the Go Agent.

Also updates serverless mini agent to emit logs from dogstatsd package to facilitate debugging.

How to test the change?

See https://datadoghq.atlassian.net/wiki/spaces/SLS/pages/2977497119/Serverless+Mini+Agent#Testing

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 64.78873% with 25 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (490a276) to head (271acfe).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #698 +/- ## ========================================== - Coverage 71.75% 71.75% -0.01% ========================================== Files 271 271 Lines 41102 41143 +41 ========================================== + Hits 29494 29521 +27 - Misses 11608 11622 +14 ``` | [Components](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [crashtracker](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `20.10% <ø> (-0.06%)` | :arrow_down: | | [crashtracker-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `8.97% <ø> (ø)` | | | [datadog-alloc](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `98.73% <ø> (ø)` | | | [data-pipeline](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `91.93% <ø> (ø)` | | | [data-pipeline-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [ddcommon](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.74% <ø> (ø)` | | | [ddcommon-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.12% <ø> (ø)` | | | [ddtelemetry](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `59.10% <ø> (ø)` | | | [ddtelemetry-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `22.13% <ø> (ø)` | | | [dogstatsd](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `89.22% <97.87%> (+0.35%)` | :arrow_up: | | [dogstatsd-client](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `79.77% <ø> (ø)` | | | [ipc](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.65% <ø> (ø)` | | | [profiling](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `84.30% <ø> (ø)` | | | [profiling-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `77.46% <ø> (ø)` | | | [serverless](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <0.00%> (ø)` | | | [sidecar](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `36.13% <ø> (ø)` | | | [sidecar-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [spawn-worker](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `50.36% <ø> (ø)` | | | [tinybytes](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `94.77% <ø> (ø)` | | | [trace-mini-agent](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `72.45% <ø> (ø)` | | | [trace-normalization](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `98.25% <ø> (ø)` | | | [trace-obfuscation](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `95.77% <ø> (ø)` | | | [trace-protobuf](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `77.67% <ø> (ø)` | | | [trace-utils](https://app.codecov.io/gh/DataDog/libdatadog/pull/698/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `93.14% <ø> (ø)` | |
pr-commenter[bot] commented 5 days ago

Benchmarks

Comparison

Benchmark execution time: 2024-10-30 18:47:42

Comparing candidate commit 271acfe in PR branch duncan-harvey/dogstatsd-metric-fixes with baseline commit 490a276 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details ### Group 1 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------------------|--------------|-----------------|----------------------------------|---------------------------------|-----------------|-----------------|-----------------|-----------------|--------------------|--------|--------|-----|------------|----|-----------| |credit_card/is_card_number/ |execution_time|4.601µs |4.614µs ± 0.002µs |4.614µs ± 0.001µs |4.616µs |4.618µs |4.619µs |4.622µs |0.17% |-0.516 |4.480 |0.05%|0.000µs |1 |200 | |credit_card/is_card_number/ |throughput |216353101.035op/s|216713537.458op/s ± 107731.325op/s|216714939.388op/s ± 67610.758op/s|216784223.533op/s|216859450.934op/s|216904499.435op/s|217325384.116op/s|0.28% |0.526 |4.524 |0.05%|7617.755op/s|1 |200 | |credit_card/is_card_number/ 3782-8224-6310-005 |execution_time|90.365µs |91.395µs ± 0.506µs |91.316µs ± 0.249µs |91.624µs |92.231µs |92.760µs |94.787µs |3.80% |1.950 |9.754 |0.55%|0.036µs |1 |200 | |credit_card/is_card_number/ 3782-8224-6310-005 |throughput |10550018.501op/s |10941842.334op/s ± 59934.790op/s |10950976.317op/s ± 29971.739op/s |10976734.608op/s |11023275.592op/s |11045999.966op/s |11066243.641op/s |1.05% |-1.823 |8.793 |0.55%|4238.030op/s|1 |200 | |credit_card/is_card_number/ 378282246310005 |execution_time|82.738µs |83.705µs ± 0.636µs |83.600µs ± 0.342µs |84.011µs |84.598µs |85.748µs |87.650µs |4.84% |1.957 |8.134 |0.76%|0.045µs |1 |200 | |credit_card/is_card_number/ 378282246310005 |throughput |11409051.085op/s |11947370.345op/s ± 89513.706op/s |11961714.738op/s ± 48953.674op/s |12005235.223op/s |12062428.620op/s |12076645.123op/s |12086408.149op/s |1.04% |-1.819 |7.182 |0.75%|6329.575op/s|1 |200 | |credit_card/is_card_number/37828224631 |execution_time|4.599µs |4.615µs ± 0.003µs |4.615µs ± 0.001µs |4.616µs |4.619µs |4.622µs |4.623µs |0.17% |-0.606 |6.459 |0.06%|0.000µs |1 |200 | |credit_card/is_card_number/37828224631 |throughput |216324849.446op/s|216686241.735op/s ± 120780.384op/s|216692773.297op/s ± 68114.838op/s|216755240.073op/s|216841534.662op/s|216891091.830op/s|217425854.473op/s|0.34% |0.619 |6.532 |0.06%|8540.463op/s|1 |200 | |credit_card/is_card_number/378282246310005 |execution_time|79.536µs |80.611µs ± 0.383µs |80.661µs ± 0.283µs |80.913µs |81.122µs |81.242µs |81.302µs |0.79% |-0.440 |-0.493 |0.47%|0.027µs |1 |200 | |credit_card/is_card_number/378282246310005 |throughput |12299780.483op/s |12405468.441op/s ± 59056.249op/s |12397504.868op/s ± 43542.895op/s |12446279.699op/s |12507622.401op/s |12547832.469op/s |12572958.363op/s |1.42% |0.459 |-0.467 |0.47%|4175.907op/s|1 |200 | |credit_card/is_card_number/37828224631000521389798 |execution_time|59.270µs |59.540µs ± 0.211µs |59.556µs ± 0.204µs |59.647µs |59.938µs |60.070µs |60.073µs |0.87% |0.439 |-0.653 |0.35%|0.015µs |1 |200 | |credit_card/is_card_number/37828224631000521389798 |throughput |16646534.866op/s |16795760.407op/s ± 59521.986op/s |16790885.306op/s ± 57221.268op/s |16857713.700op/s |16869956.211op/s |16871438.965op/s |16871888.060op/s |0.48% |-0.427 |-0.673 |0.35%|4208.840op/s|1 |200 | |credit_card/is_card_number/x371413321323331 |execution_time|7.218µs |7.223µs ± 0.006µs |7.222µs ± 0.002µs |7.224µs |7.228µs |7.238µs |7.293µs |0.98% |8.615 |95.019 |0.08%|0.000µs |1 |200 | |credit_card/is_card_number/x371413321323331 |throughput |137113929.003op/s|138449488.377op/s ± 113911.393op/s|138462061.396op/s ± 35076.074op/s|138499968.838op/s|138519434.277op/s|138533791.994op/s|138536684.514op/s|0.05% |-8.559 |94.068 |0.08%|8054.752op/s|1 |200 | |credit_card/is_card_number_no_luhn/ |execution_time|4.605µs |4.614µs ± 0.002µs |4.614µs ± 0.001µs |4.616µs |4.617µs |4.619µs |4.622µs |0.17% |-0.192 |2.461 |0.04%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/ |throughput |216347591.408op/s|216709628.637op/s ± 95215.470op/s |216708614.167op/s ± 63184.052op/s|216768531.372op/s|216857577.390op/s|216882680.716op/s|217166865.327op/s|0.21% |0.198 |2.473 |0.04%|6732.750op/s|1 |200 | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |execution_time|73.914µs |74.411µs ± 0.165µs |74.429µs ± 0.097µs |74.509µs |74.646µs |74.748µs |75.210µs |1.05% |0.147 |2.275 |0.22%|0.012µs |1 |200 | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |throughput |13296079.360op/s |13438918.565op/s ± 29778.914op/s |13435596.470op/s ± 17540.872op/s |13455364.855op/s |13489101.615op/s |13509636.455op/s |13529289.559op/s |0.70% |-0.119 |2.192 |0.22%|2105.687op/s|1 |200 | |credit_card/is_card_number_no_luhn/ 378282246310005 |execution_time|66.327µs |66.813µs ± 0.245µs |66.798µs ± 0.184µs |66.974µs |67.259µs |67.429µs |67.528µs |1.09% |0.573 |-0.214 |0.37%|0.017µs |1 |200 | |credit_card/is_card_number_no_luhn/ 378282246310005 |throughput |14808734.824op/s |14967354.084op/s ± 54761.508op/s |14970444.667op/s ± 41216.672op/s |15012533.593op/s |15039518.592op/s |15048121.943op/s |15076898.212op/s |0.71% |-0.557 |-0.242 |0.36%|3872.223op/s|1 |200 | |credit_card/is_card_number_no_luhn/37828224631 |execution_time|4.602µs |4.615µs ± 0.002µs |4.615µs ± 0.001µs |4.616µs |4.619µs |4.620µs |4.621µs |0.13% |-0.460 |3.521 |0.05%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/37828224631 |throughput |216421349.207op/s|216698809.064op/s ± 109082.268op/s|216694318.185op/s ± 63114.201op/s|216768498.119op/s|216859740.527op/s|216902175.030op/s|217290751.161op/s|0.28% |0.468 |3.557 |0.05%|7713.281op/s|1 |200 | |credit_card/is_card_number_no_luhn/378282246310005 |execution_time|62.235µs |62.657µs ± 0.167µs |62.633µs ± 0.111µs |62.741µs |62.957µs |63.160µs |63.197µs |0.90% |0.840 |0.564 |0.27%|0.012µs |1 |200 | |credit_card/is_card_number_no_luhn/378282246310005 |throughput |15823636.082op/s |15960022.904op/s ± 42552.617op/s |15966072.113op/s ± 28456.159op/s |15994667.380op/s |16005715.641op/s |16031321.118op/s |16068198.254op/s |0.64% |-0.825 |0.535 |0.27%|3008.924op/s|1 |200 | |credit_card/is_card_number_no_luhn/37828224631000521389798|execution_time|59.261µs |59.524µs ± 0.207µs |59.521µs ± 0.165µs |59.633µs |59.936µs |60.027µs |60.107µs |0.98% |0.546 |-0.460 |0.35%|0.015µs |1 |200 | |credit_card/is_card_number_no_luhn/37828224631000521389798|throughput |16636942.985op/s |16800133.217op/s ± 58189.463op/s |16800703.111op/s ± 46763.799op/s |16859706.543op/s |16870224.757op/s |16872456.876op/s |16874460.243op/s |0.44% |-0.533 |-0.486 |0.35%|4114.616op/s|1 |200 | |credit_card/is_card_number_no_luhn/x371413321323331 |execution_time|7.217µs |7.223µs ± 0.003µs |7.222µs ± 0.002µs |7.224µs |7.228µs |7.230µs |7.230µs |0.11% |0.681 |-0.181 |0.04%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/x371413321323331 |throughput |138308401.372op/s|138452640.323op/s ± 52729.745op/s |138462096.007op/s ± 35390.264op/s|138495253.075op/s|138514898.663op/s|138537338.999op/s|138560315.305op/s|0.07% |-0.680 |-0.184 |0.04%|3728.556op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------------------|--------------|------------------------------------------------------------|-------------------|------------------------|---------------| |credit_card/is_card_number/ |execution_time|[4.614µs; 4.615µs] or [-0.007%; +0.007%] |None |None |None | |credit_card/is_card_number/ |throughput |[216698606.932op/s; 216728467.983op/s] or [-0.007%; +0.007%]|None |None |None | |credit_card/is_card_number/ 3782-8224-6310-005 |execution_time|[91.325µs; 91.465µs] or [-0.077%; +0.077%] |None |None |None | |credit_card/is_card_number/ 3782-8224-6310-005 |throughput |[10933535.948op/s; 10950148.719op/s] or [-0.076%; +0.076%] |None |None |None | |credit_card/is_card_number/ 378282246310005 |execution_time|[83.617µs; 83.793µs] or [-0.105%; +0.105%] |None |None |None | |credit_card/is_card_number/ 378282246310005 |throughput |[11934964.606op/s; 11959776.084op/s] or [-0.104%; +0.104%] |None |None |None | |credit_card/is_card_number/37828224631 |execution_time|[4.615µs; 4.615µs] or [-0.008%; +0.008%] |None |None |None | |credit_card/is_card_number/37828224631 |throughput |[216669502.736op/s; 216702980.735op/s] or [-0.008%; +0.008%]|None |None |None | |credit_card/is_card_number/378282246310005 |execution_time|[80.558µs; 80.664µs] or [-0.066%; +0.066%] |None |None |None | |credit_card/is_card_number/378282246310005 |throughput |[12397283.813op/s; 12413653.069op/s] or [-0.066%; +0.066%] |None |None |None | |credit_card/is_card_number/37828224631000521389798 |execution_time|[59.510µs; 59.569µs] or [-0.049%; +0.049%] |None |None |None | |credit_card/is_card_number/37828224631000521389798 |throughput |[16787511.232op/s; 16804009.582op/s] or [-0.049%; +0.049%] |None |None |None | |credit_card/is_card_number/x371413321323331 |execution_time|[7.222µs; 7.224µs] or [-0.011%; +0.011%] |None |None |None | |credit_card/is_card_number/x371413321323331 |throughput |[138433701.353op/s; 138465275.400op/s] or [-0.011%; +0.011%]|None |None |None | |credit_card/is_card_number_no_luhn/ |execution_time|[4.614µs; 4.615µs] or [-0.006%; +0.006%] |None |None |None | |credit_card/is_card_number_no_luhn/ |throughput |[216696432.689op/s; 216722824.586op/s] or [-0.006%; +0.006%]|None |None |None | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |execution_time|[74.388µs; 74.434µs] or [-0.031%; +0.031%] |None |None |None | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |throughput |[13434791.494op/s; 13443045.636op/s] or [-0.031%; +0.031%] |None |None |None | |credit_card/is_card_number_no_luhn/ 378282246310005 |execution_time|[66.779µs; 66.847µs] or [-0.051%; +0.051%] |None |None |None | |credit_card/is_card_number_no_luhn/ 378282246310005 |throughput |[14959764.665op/s; 14974943.502op/s] or [-0.051%; +0.051%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631 |execution_time|[4.614µs; 4.615µs] or [-0.007%; +0.007%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631 |throughput |[216683691.311op/s; 216713926.817op/s] or [-0.007%; +0.007%]|None |None |None | |credit_card/is_card_number_no_luhn/378282246310005 |execution_time|[62.634µs; 62.680µs] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number_no_luhn/378282246310005 |throughput |[15954125.521op/s; 15965920.288op/s] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631000521389798|execution_time|[59.495µs; 59.553µs] or [-0.048%; +0.048%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631000521389798|throughput |[16792068.717op/s; 16808197.717op/s] or [-0.048%; +0.048%] |None |None |None | |credit_card/is_card_number_no_luhn/x371413321323331 |execution_time|[7.222µs; 7.223µs] or [-0.005%; +0.005%] |None |None |None | |credit_card/is_card_number_no_luhn/x371413321323331 |throughput |[138445332.488op/s; 138459948.159op/s] or [-0.005%; +0.005%]|None |None |None | ### Group 2 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------|--------------|---------|-------------------|-------------------|---------|---------|---------|---------|--------------------|--------|--------|-----|-------|----|-----------| |benching string interning on wordpress profile|execution_time|142.933µs|143.914µs ± 0.351µs|143.887µs ± 0.174µs|144.062µs|144.511µs|145.086µs|145.414µs|1.06% |1.030 |3.332 |0.24%|0.025µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------|--------------|--------------------------------------------|-------------------|------------------------|---------------| |benching string interning on wordpress profile|execution_time|[143.866µs; 143.963µs] or [-0.034%; +0.034%]|None |None |None | ### Group 3 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-----------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |tags/replace_trace_tags|execution_time|2.584µs|2.636µs ± 0.018µs|2.634µs ± 0.004µs|2.642µs|2.679µs|2.687µs|2.687µs|2.01% |0.204 |2.627 |0.70%|0.001µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-----------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |tags/replace_trace_tags|execution_time|[2.634µs; 2.639µs] or [-0.097%; +0.097%]|None |None |None | ### Group 4 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------|--------------|---------|--------------------|-------------------|---------|---------|---------|---------|--------------------|--------|--------|-----|-------|----|-----------| |normalization/normalize_trace/test_trace|execution_time|256.759ns|269.149ns ± 15.503ns|261.660ns ± 3.268ns|277.119ns|303.816ns|310.306ns|313.790ns|19.92% |1.385 |0.560 |5.75%|1.096ns|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------|--------------|--------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_trace/test_trace|execution_time|[267.000ns; 271.298ns] or [-0.798%; +0.798%]|None |None |None | ### Group 5 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |--------------------|--------------|-------|-----------------|-----------------|-------|-------|--------|--------|--------------------|--------|--------|------|-------|----|-----------| |write only interface|execution_time|1.375µs|3.208µs ± 1.386µs|3.064µs ± 0.029µs|3.088µs|3.149µs|13.833µs|14.918µs|386.88% |7.591 |57.854 |43.09%|0.098µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |--------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |write only interface|execution_time|[3.016µs; 3.400µs] or [-5.987%; +5.987%]|None |None |None | ### Group 6 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |redis/obfuscate_redis_string|execution_time|37.576µs|38.218µs ± 1.234µs|37.639µs ± 0.046µs|37.767µs|40.881µs|41.030µs|41.104µs|9.20% |1.700 |0.914 |3.22%|0.087µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |redis/obfuscate_redis_string|execution_time|[38.047µs; 38.389µs] or [-0.447%; +0.447%]|None |None |None | ### Group 7 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |sql/obfuscate_sql_string|execution_time|72.980µs|73.111µs ± 0.170µs|73.086µs ± 0.031µs|73.119µs|73.243µs|73.485µs|75.017µs|2.64% |8.432 |84.651 |0.23%|0.012µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |sql/obfuscate_sql_string|execution_time|[73.087µs; 73.135µs] or [-0.032%; +0.032%]|None |None |None | ### Group 8 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-----------------|--------------|--------|-------------------|------------------|--------|--------|--------|---------|--------------------|--------|--------|------|-------|----|-----------| |two way interface|execution_time|18.906µs|25.304µs ± 10.963µs|20.309µs ± 0.232µs|26.833µs|38.663µs|42.170µs|107.001µs|426.87% |4.036 |24.478 |43.22%|0.775µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-----------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |two way interface|execution_time|[23.784µs; 26.823µs] or [-6.004%; +6.004%]|None |None |None | ### Group 9 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------------------------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |benching deserializing traces from msgpack to their internal representation |execution_time|1.133µs|1.191µs ± 0.022µs|1.195µs ± 0.014µs|1.210µs|1.213µs|1.216µs|1.217µs|1.79% |-1.053 |0.339 |1.88%|0.002µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------------------------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |benching deserializing traces from msgpack to their internal representation |execution_time|[1.188µs; 1.194µs] or [-0.261%; +0.261%]|None |None |None | ### Group 10 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-------------------------------------------------------------------------------------------------------|--------------|----------------|--------------------------------|--------------------------------|----------------|----------------|----------------|----------------|--------------------|--------|--------|-----|------------|----|-----------| |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|execution_time|623.042µs |624.391µs ± 0.435µs |624.407µs ± 0.298µs |624.696µs |625.027µs |625.228µs |625.716µs |0.21% |-0.299 |0.525 |0.07%|0.031µs |1 |200 | |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|throughput |1598170.050op/s |1601560.593op/s ± 1115.584op/s |1601519.705op/s ± 763.508op/s |1602293.615op/s |1603459.000op/s |1604452.307op/s |1605028.416op/s |0.22% |0.304 |0.529 |0.07%|78.884op/s |1 |200 | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |execution_time|463.179µs |464.036µs ± 0.475µs |463.975µs ± 0.347µs |464.329µs |464.917µs |465.305µs |465.498µs |0.33% |0.547 |-0.117 |0.10%|0.034µs |1 |200 | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |throughput |2148237.671op/s |2155006.649op/s ± 2205.199op/s |2155289.151op/s ± 1613.728op/s |2156737.553op/s |2158128.372op/s |2158471.276op/s |2158990.565op/s |0.17% |-0.542 |-0.126 |0.10%|155.931op/s |1 |200 | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |execution_time|178.105µs |178.362µs ± 0.104µs |178.366µs ± 0.057µs |178.410µs |178.546µs |178.616µs |178.811µs |0.25% |0.480 |1.466 |0.06%|0.007µs |1 |200 | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |throughput |5592489.478op/s |5606582.809op/s ± 3265.630op/s |5606438.927op/s ± 1796.808op/s |5608567.922op/s |5611459.454op/s |5613791.646op/s |5614668.582op/s |0.15% |-0.474 |1.452 |0.06%|230.915op/s |1 |200 | |normalization/normalize_service/normalize_service/[empty string] |execution_time|46.603µs |46.784µs ± 0.068µs |46.778µs ± 0.050µs |46.832µs |46.893µs |46.941µs |46.953µs |0.37% |0.182 |-0.289 |0.15%|0.005µs |1 |200 | |normalization/normalize_service/normalize_service/[empty string] |throughput |21297909.723op/s|21374758.946op/s ± 31118.330op/s|21377726.231op/s ± 22897.549op/s|21397448.388op/s|21422645.368op/s|21437828.303op/s|21458009.339op/s|0.38% |-0.175 |-0.290 |0.15%|2200.398op/s|1 |200 | |normalization/normalize_service/normalize_service/test_ASCII |execution_time|49.100µs |49.464µs ± 0.168µs |49.449µs ± 0.119µs |49.578µs |49.766µs |49.824µs |49.952µs |1.02% |0.252 |-0.387 |0.34%|0.012µs |1 |200 | |normalization/normalize_service/normalize_service/test_ASCII |throughput |20019297.672op/s|20216800.626op/s ± 68636.211op/s|20222672.856op/s ± 48802.280op/s|20268754.255op/s|20323854.237op/s|20354600.536op/s|20366714.536op/s|0.71% |-0.236 |-0.398 |0.34%|4853.313op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-------------------------------------------------------------------------------------------------------|--------------|----------------------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|execution_time|[624.331µs; 624.452µs] or [-0.010%; +0.010%] |None |None |None | |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|throughput |[1601405.984op/s; 1601715.203op/s] or [-0.010%; +0.010%] |None |None |None | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |execution_time|[463.970µs; 464.102µs] or [-0.014%; +0.014%] |None |None |None | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |throughput |[2154701.030op/s; 2155312.268op/s] or [-0.014%; +0.014%] |None |None |None | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |execution_time|[178.347µs; 178.376µs] or [-0.008%; +0.008%] |None |None |None | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |throughput |[5606130.224op/s; 5607035.394op/s] or [-0.008%; +0.008%] |None |None |None | |normalization/normalize_service/normalize_service/[empty string] |execution_time|[46.775µs; 46.794µs] or [-0.020%; +0.020%] |None |None |None | |normalization/normalize_service/normalize_service/[empty string] |throughput |[21370446.245op/s; 21379071.648op/s] or [-0.020%; +0.020%]|None |None |None | |normalization/normalize_service/normalize_service/test_ASCII |execution_time|[49.441µs; 49.488µs] or [-0.047%; +0.047%] |None |None |None | |normalization/normalize_service/normalize_service/test_ASCII |throughput |[20207288.307op/s; 20226312.944op/s] or [-0.047%; +0.047%]|None |None |None | ### Group 11 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |--------------------------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |concentrator/add_spans_to_concentrator|execution_time|9.069ms|9.113ms ± 0.025ms|9.111ms ± 0.010ms|9.122ms|9.135ms|9.194ms|9.358ms|2.71% |5.201 |44.599 |0.28%|0.002ms|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |--------------------------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |concentrator/add_spans_to_concentrator|execution_time|[9.110ms; 9.117ms] or [-0.039%; +0.039%]|None |None |None | ### Group 12 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|271acfe |1730313426 |duncan-harvey/dogstatsd-metric-fixes| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-------------------------------------------------------------------------------------------------------|--------------|----------------|---------------------------------|---------------------------------|----------------|----------------|----------------|----------------|--------------------|--------|--------|-----|-------------|----|-----------| |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|execution_time|186.932µs |191.106µs ± 1.269µs |191.139µs ± 0.851µs |191.955µs |193.143µs |193.876µs |194.057µs |1.53% |-0.216 |0.177 |0.66%|0.090µs |1 |200 | |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|throughput |5153134.197op/s |5232929.234op/s ± 34801.602op/s |5231797.184op/s ± 23312.463op/s |5255867.409op/s |5293289.391op/s |5306488.031op/s |5349549.413op/s |2.25% |0.259 |0.238 |0.66%|2460.845op/s |1 |200 | |normalization/normalize_name/normalize_name/bad-name |execution_time|18.217µs |18.255µs ± 0.028µs |18.251µs ± 0.021µs |18.274µs |18.292µs |18.325µs |18.413µs |0.88% |1.258 |3.775 |0.15%|0.002µs |1 |200 | |normalization/normalize_name/normalize_name/bad-name |throughput |54310480.128op/s|54780171.620op/s ± 84789.962op/s |54790884.761op/s ± 62832.461op/s |54850491.737op/s|54877810.719op/s|54891841.859op/s|54894163.587op/s|0.19% |-1.239 |3.649 |0.15%|5995.556op/s |1 |200 | |normalization/normalize_name/normalize_name/good |execution_time|11.326µs |11.369µs ± 0.034µs |11.361µs ± 0.019µs |11.387µs |11.422µs |11.453µs |11.643µs |2.49% |3.012 |19.369 |0.30%|0.002µs |1 |200 | |normalization/normalize_name/normalize_name/good |throughput |85886960.682op/s|87957738.517op/s ± 261821.149op/s|88021570.787op/s ± 146208.252op/s|88121285.180op/s|88244386.221op/s|88283241.330op/s|88295226.125op/s|0.31% |-2.905 |18.208 |0.30%|18513.551op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-------------------------------------------------------------------------------------------------------|--------------|----------------------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|execution_time|[190.930µs; 191.282µs] or [-0.092%; +0.092%] |None |None |None | |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|throughput |[5228106.066op/s; 5237752.401op/s] or [-0.092%; +0.092%] |None |None |None | |normalization/normalize_name/normalize_name/bad-name |execution_time|[18.251µs; 18.259µs] or [-0.021%; +0.021%] |None |None |None | |normalization/normalize_name/normalize_name/bad-name |throughput |[54768420.547op/s; 54791922.694op/s] or [-0.021%; +0.021%]|None |None |None | |normalization/normalize_name/normalize_name/good |execution_time|[11.364µs; 11.374µs] or [-0.042%; +0.042%] |None |None |None | |normalization/normalize_name/normalize_name/good |throughput |[87921452.624op/s; 87994024.410op/s] or [-0.041%; +0.041%]|None |None |None |

Baseline

Omitted due to size.