Closed duncanpharvey closed 4 days ago
Attention: Patch coverage is 64.78873%
with 25 lines
in your changes missing coverage. Please review.
Project coverage is 71.75%. Comparing base (
490a276
) to head (271acfe
).
Benchmark execution time: 2024-10-30 18:47:42
Comparing candidate commit 271acfe in PR branch duncan-harvey/dogstatsd-metric-fixes
with baseline commit 490a276 in branch main
.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.
Omitted due to size.
What does this PR do?
Fixes two issues that prevent DogStatsD metrics from being submitted in some environments.
In addition, lazily initialize static regex for dogstatsd metrics.
Motivation
https://datadoghq.atlassian.net/browse/SVLS-5799
Additional Notes
Some DogStatsD messages in Azure Spring App environments were larger than 1KB, causing them to be truncated. These messages also include container ids with the pattern
c:*
.DogStatsD protocol v1.2
The max buffer size value of
8192
bytes is used to match the default value used in the Go Agent.Also updates serverless mini agent to emit logs from dogstatsd package to facilitate debugging.
How to test the change?
See https://datadoghq.atlassian.net/wiki/spaces/SLS/pages/2977497119/Serverless+Mini+Agent#Testing