Open danielsn opened 3 days ago
Attention: Patch coverage is 86.60714%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 70.89%. Comparing base (
fb66952
) to head (9c74207
).
Benchmark execution time: 2024-11-01 21:24:09
Comparing candidate commit 9c74207 in PR branch dsn/crashtracker-receiver-timeout
with baseline commit fb66952 in branch main
.
Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.
execution_time
[-101.543ns; -94.982ns] or [-3.724%; -3.483%]Omitted due to size.
What does this PR do?
Adds a timeout to the crashtracker receiver, enabling it to post a partial crash report if the collector hangs. Previously, a collector hang could cause the receiver to also hang.
Motivation
This implements a mitigation from the RFC.
Additional Notes
There is an open question about how to configure this timeout. Currently, we're offering an environment variable. We could take the value from the config, but that is passed on the socket, so its odd for a timeout on the socket to depend on a value that came on the socket.
How to test the change?
Added two new tests.