Closed sanchda closed 2 weeks ago
Attention: Patch coverage is 93.82716%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 71.62%. Comparing base (
85c32c8
) to head (637a057
).
Benchmark execution time: 2024-11-11 04:52:55
Comparing candidate commit 637a057d in PR branch sanchda/test_31138_fix
with baseline commit 85c32c8f in branch main
.
Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.
execution_time
[-37.943ns; -27.604ns] or [-3.082%; -2.242%]Omitted due to size.
What does this PR do?
This patch adds a test without changing any functionality. During development of a recent crashtracking fix, I had a C-language repro for this situation which I'd test against the FFI. Now that the dust has settled a bit and we're doing some more feature work with crashtracking, it's time to add a regression test for this condition.
Motivation
This was the most significant defect end-users have experienced for crashtracking to date. We should check it explicitly.