search

DataDog / libdatadog

Datadog shared rust-based library. For now only used in other products (e.g. Ruby or PHP libraries).
Apache License 2.0
48 stars 9 forks source link

fix(crashtracker) : Fix crash when sending crashinfo #756

Closed gleocadie closed 2 days ago

gleocadie commented 5 days ago

What does this PR do?

When calling ddog_crasht_CrashInfo_upload_to_endpoint, if the ProcInfo is not set, the process crashes with panic

 thread '<unnamed>' panicked at crashtracker/src/rfc5_crash_info/mod.rs:74:41:

Motivation

Fix a bug and missing API.

How to test the change?

The crashinfo example runs in CI. Added calls to ddog_crasht_CrashInfo_set_procinfo to fix the crash

pr-commenter[bot] commented 5 days ago

Benchmarks

Comparison

Benchmark execution time: 2024-11-25 17:08:13

Comparing candidate commit 398a63d8 in PR branch gleocadie/fix-bug-in-crashtracker with baseline commit 25079f5c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details ### Group 1 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-------------------------------------------------------------------------------------------------------|--------------|----------------|---------------------------------|--------------------------------|----------------|----------------|----------------|----------------|--------------------|--------|--------|-----|------------|----|-----------| |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|execution_time|302.068µs |306.029µs ± 1.537µs |306.072µs ± 0.948µs |306.919µs |308.685µs |309.409µs |309.821µs |1.22% |0.020 |-0.128 |0.50%|0.109µs |1 |200 | |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|throughput |3227674.415op/s |3267743.252op/s ± 16410.442op/s |3267203.919op/s ± 10123.148op/s |3279020.422op/s |3296604.215op/s |3303448.381op/s |3310515.300op/s |1.33% |0.008 |-0.125 |0.50%|1160.393op/s|1 |200 | |normalization/normalize_name/normalize_name/bad-name |execution_time|28.022µs |28.229µs ± 0.091µs |28.221µs ± 0.057µs |28.285µs |28.409µs |28.455µs |28.462µs |0.85% |0.435 |-0.023 |0.32%|0.006µs |1 |200 | |normalization/normalize_name/normalize_name/bad-name |throughput |35134802.779op/s|35424329.016op/s ± 114369.639op/s|35434877.086op/s ± 71901.832op/s|35500511.566op/s|35593400.800op/s|35656330.176op/s|35685805.696op/s|0.71% |-0.418 |-0.039 |0.32%|8087.155op/s|1 |200 | |normalization/normalize_name/normalize_name/good |execution_time|16.568µs |16.651µs ± 0.035µs |16.649µs ± 0.022µs |16.674µs |16.711µs |16.737µs |16.771µs |0.73% |0.265 |0.127 |0.21%|0.002µs |1 |200 | |normalization/normalize_name/normalize_name/good |throughput |59627101.282op/s|60056579.355op/s ± 124886.388op/s|60062942.884op/s ± 80599.767op/s|60137213.087op/s|60270436.582op/s|60306950.979op/s|60356568.033op/s|0.49% |-0.252 |0.111 |0.21%|8830.801op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-------------------------------------------------------------------------------------------------------|--------------|----------------------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|execution_time|[305.816µs; 306.242µs] or [-0.070%; +0.070%] |None |None |None | |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|throughput |[3265468.923op/s; 3270017.582op/s] or [-0.070%; +0.070%] |None |None |None | |normalization/normalize_name/normalize_name/bad-name |execution_time|[28.217µs; 28.242µs] or [-0.045%; +0.045%] |None |None |None | |normalization/normalize_name/normalize_name/bad-name |throughput |[35408478.484op/s; 35440179.548op/s] or [-0.045%; +0.045%]|None |None |None | |normalization/normalize_name/normalize_name/good |execution_time|[16.646µs; 16.656µs] or [-0.029%; +0.029%] |None |None |None | |normalization/normalize_name/normalize_name/good |throughput |[60039271.303op/s; 60073887.408op/s] or [-0.029%; +0.029%]|None |None |None | ### Group 2 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |redis/obfuscate_redis_string|execution_time|39.166µs|39.725µs ± 0.970µs|39.280µs ± 0.053µs|39.378µs|41.772µs|41.834µs|43.355µs|10.37% |1.760 |1.357 |2.44%|0.069µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |redis/obfuscate_redis_string|execution_time|[39.590µs; 39.859µs] or [-0.338%; +0.338%]|None |None |None | ### Group 3 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-----------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |tags/replace_trace_tags|execution_time|2.678µs|2.704µs ± 0.017µs|2.699µs ± 0.005µs|2.704µs|2.746µs|2.753µs|2.785µs|3.16% |1.960 |4.154 |0.62%|0.001µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-----------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |tags/replace_trace_tags|execution_time|[2.701µs; 2.706µs] or [-0.086%; +0.086%]|None |None |None | ### Group 4 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------------------|--------------|-----------------|----------------------------------|----------------------------------|-----------------|-----------------|-----------------|-----------------|--------------------|--------|--------|-----|-------------|----|-----------| |credit_card/is_card_number/ |execution_time|4.617µs |4.632µs ± 0.005µs |4.632µs ± 0.003µs |4.635µs |4.638µs |4.641µs |4.670µs |0.82% |1.450 |12.582 |0.11%|0.000µs |1 |200 | |credit_card/is_card_number/ |throughput |214150030.198op/s|215908338.412op/s ± 245565.455op/s|215905645.966op/s ± 133746.381op/s|216038848.168op/s|216288890.761op/s|216477273.074op/s|216601246.536op/s|0.32% |-1.408 |12.261 |0.11%|17364.100op/s|1 |200 | |credit_card/is_card_number/ 3782-8224-6310-005 |execution_time|90.781µs |91.678µs ± 0.529µs |91.611µs ± 0.270µs |91.884µs |92.454µs |92.878µs |96.211µs |5.02% |3.361 |25.453 |0.58%|0.037µs |1 |200 | |credit_card/is_card_number/ 3782-8224-6310-005 |throughput |10393774.339op/s |10908119.551op/s ± 61828.508op/s |10915719.181op/s ± 32253.193op/s |10947713.695op/s |10981006.715op/s |11003588.268op/s |11015499.718op/s |0.91% |-3.095 |22.525 |0.57%|4371.936op/s |1 |200 | |credit_card/is_card_number/ 378282246310005 |execution_time|83.738µs |84.032µs ± 0.366µs |83.986µs ± 0.034µs |84.023µs |84.223µs |84.491µs |88.961µs |5.92% |12.360 |163.645 |0.43%|0.026µs |1 |200 | |credit_card/is_card_number/ 378282246310005 |throughput |11240913.478op/s |11900483.124op/s ± 49175.602op/s |11906766.447op/s ± 4775.465op/s |11911084.055op/s |11919900.534op/s |11929955.736op/s |11942016.732op/s |0.30% |-12.190 |160.506 |0.41%|3477.240op/s |1 |200 | |credit_card/is_card_number/37828224631 |execution_time|4.616µs |4.633µs ± 0.007µs |4.632µs ± 0.003µs |4.635µs |4.639µs |4.665µs |4.692µs |1.29% |4.778 |34.266 |0.15%|0.001µs |1 |200 | |credit_card/is_card_number/37828224631 |throughput |213131002.022op/s|215856584.622op/s ± 332162.352op/s|215883355.413op/s ± 124936.087op/s|216005075.669op/s|216184822.470op/s|216359338.954op/s|216623109.602op/s|0.34% |-4.716 |33.661 |0.15%|23487.425op/s|1 |200 | |credit_card/is_card_number/378282246310005 |execution_time|81.028µs |81.198µs ± 0.142µs |81.156µs ± 0.033µs |81.203µs |81.501µs |81.843µs |81.873µs |0.88% |2.587 |7.627 |0.17%|0.010µs |1 |200 | |credit_card/is_card_number/378282246310005 |throughput |12213984.678op/s |12315604.954op/s ± 21388.374op/s |12321916.018op/s ± 4952.881op/s |12325804.819op/s |12334771.140op/s |12340574.200op/s |12341457.064op/s |0.16% |-2.571 |7.534 |0.17%|1512.386op/s |1 |200 | |credit_card/is_card_number/37828224631000521389798 |execution_time|59.047µs |59.273µs ± 0.158µs |59.259µs ± 0.136µs |59.395µs |59.564µs |59.697µs |59.805µs |0.92% |0.684 |0.002 |0.27%|0.011µs |1 |200 | |credit_card/is_card_number/37828224631000521389798 |throughput |16721084.840op/s |16871078.075op/s ± 44953.717op/s |16875044.165op/s ± 38518.164op/s |16912122.728op/s |16926356.863op/s |16933439.671op/s |16935772.394op/s |0.36% |-0.672 |-0.028 |0.27%|3178.708op/s |1 |200 | |credit_card/is_card_number/x371413321323331 |execution_time|6.831µs |6.842µs ± 0.004µs |6.842µs ± 0.002µs |6.843µs |6.847µs |6.850µs |6.855µs |0.19% |-0.041 |1.061 |0.05%|0.000µs |1 |200 | |credit_card/is_card_number/x371413321323331 |throughput |145884379.146op/s|146162641.935op/s ± 76561.039op/s |146160317.474op/s ± 37811.190op/s |146198527.052op/s|146296090.283op/s|146355139.375op/s|146381190.638op/s|0.15% |0.046 |1.058 |0.05%|5413.683op/s |1 |200 | |credit_card/is_card_number_no_luhn/ |execution_time|4.615µs |4.633µs ± 0.004µs |4.633µs ± 0.003µs |4.636µs |4.639µs |4.642µs |4.643µs |0.22% |-0.290 |0.691 |0.09%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/ |throughput |215393093.893op/s|215863219.220op/s ± 200720.961op/s|215857335.800op/s ± 137127.805op/s|215992050.434op/s|216174244.357op/s|216311209.919op/s|216664305.002op/s|0.37% |0.298 |0.705 |0.09%|14193.115op/s|1 |200 | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |execution_time|72.831µs |73.609µs ± 0.204µs |73.645µs ± 0.075µs |73.706µs |73.802µs |73.999µs |75.118µs |2.00% |1.122 |15.706 |0.28%|0.014µs |1 |200 | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |throughput |13312358.538op/s |13585449.244op/s ± 37555.327op/s |13578605.549op/s ± 13849.419op/s |13598762.173op/s |13642247.586op/s |13703396.236op/s |13730414.220op/s |1.12% |-0.988 |14.850 |0.28%|2655.563op/s |1 |200 | |credit_card/is_card_number_no_luhn/ 378282246310005 |execution_time|64.754µs |65.101µs ± 0.215µs |65.062µs ± 0.145µs |65.254µs |65.465µs |65.732µs |65.793µs |1.12% |0.757 |0.265 |0.33%|0.015µs |1 |200 | |credit_card/is_card_number_no_luhn/ 378282246310005 |throughput |15199279.830op/s |15360932.491op/s ± 50578.908op/s |15370010.054op/s ± 34226.112op/s |15398487.099op/s |15426076.703op/s |15441210.166op/s |15442968.516op/s |0.47% |-0.740 |0.224 |0.33%|3576.469op/s |1 |200 | |credit_card/is_card_number_no_luhn/37828224631 |execution_time|4.614µs |4.633µs ± 0.004µs |4.633µs ± 0.002µs |4.636µs |4.639µs |4.642µs |4.642µs |0.20% |-0.397 |2.480 |0.08%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/37828224631 |throughput |215429215.809op/s|215841584.150op/s ± 172381.929op/s|215856529.091op/s ± 110852.442op/s|215956800.250op/s|216081549.498op/s|216207392.657op/s|216725320.504op/s|0.40% |0.407 |2.524 |0.08%|12189.243op/s|1 |200 | |credit_card/is_card_number_no_luhn/378282246310005 |execution_time|63.304µs |63.579µs ± 0.087µs |63.582µs ± 0.056µs |63.643µs |63.708µs |63.749µs |63.819µs |0.37% |-0.394 |0.409 |0.14%|0.006µs |1 |200 | |credit_card/is_card_number_no_luhn/378282246310005 |throughput |15669289.917op/s |15728514.778op/s ± 21463.545op/s |15727697.416op/s ± 13853.419op/s |15740672.626op/s |15765951.221op/s |15790665.157op/s |15796684.276op/s |0.44% |0.403 |0.421 |0.14%|1517.702op/s |1 |200 | |credit_card/is_card_number_no_luhn/37828224631000521389798|execution_time|59.022µs |59.210µs ± 0.117µs |59.214µs ± 0.090µs |59.270µs |59.415µs |59.533µs |59.780µs |0.96% |1.005 |1.889 |0.20%|0.008µs |1 |200 | |credit_card/is_card_number_no_luhn/37828224631000521389798|throughput |16728069.302op/s |16889135.299op/s ± 33367.959op/s |16887863.331op/s ± 25701.756op/s |16918288.870op/s |16926923.322op/s |16938965.568op/s |16942730.646op/s |0.32% |-0.988 |1.805 |0.20%|2359.471op/s |1 |200 | |credit_card/is_card_number_no_luhn/x371413321323331 |execution_time|6.832µs |6.841µs ± 0.005µs |6.841µs ± 0.002µs |6.842µs |6.847µs |6.852µs |6.893µs |0.77% |5.367 |49.821 |0.08%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/x371413321323331 |throughput |145067357.592op/s|146182177.240op/s ± 111751.753op/s|146186704.319op/s ± 38702.345op/s |146226668.094op/s|146307727.852op/s|146362027.742op/s|146367400.396op/s|0.12% |-5.314 |49.133 |0.08%|7902.042op/s |1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------------------|--------------|------------------------------------------------------------|-------------------|------------------------|---------------| |credit_card/is_card_number/ |execution_time|[4.631µs; 4.632µs] or [-0.016%; +0.016%] |None |None |None | |credit_card/is_card_number/ |throughput |[215874305.402op/s; 215942371.423op/s] or [-0.016%; +0.016%]|None |None |None | |credit_card/is_card_number/ 3782-8224-6310-005 |execution_time|[91.604µs; 91.751µs] or [-0.080%; +0.080%] |None |None |None | |credit_card/is_card_number/ 3782-8224-6310-005 |throughput |[10899550.714op/s; 10916688.387op/s] or [-0.079%; +0.079%] |None |None |None | |credit_card/is_card_number/ 378282246310005 |execution_time|[83.981µs; 84.082µs] or [-0.060%; +0.060%] |None |None |None | |credit_card/is_card_number/ 378282246310005 |throughput |[11893667.858op/s; 11907298.389op/s] or [-0.057%; +0.057%] |None |None |None | |credit_card/is_card_number/37828224631 |execution_time|[4.632µs; 4.634µs] or [-0.021%; +0.021%] |None |None |None | |credit_card/is_card_number/37828224631 |throughput |[215810550.114op/s; 215902619.129op/s] or [-0.021%; +0.021%]|None |None |None | |credit_card/is_card_number/378282246310005 |execution_time|[81.178µs; 81.218µs] or [-0.024%; +0.024%] |None |None |None | |credit_card/is_card_number/378282246310005 |throughput |[12312640.731op/s; 12318569.177op/s] or [-0.024%; +0.024%] |None |None |None | |credit_card/is_card_number/37828224631000521389798 |execution_time|[59.252µs; 59.295µs] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number/37828224631000521389798 |throughput |[16864847.923op/s; 16877308.228op/s] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number/x371413321323331 |execution_time|[6.841µs; 6.842µs] or [-0.007%; +0.007%] |None |None |None | |credit_card/is_card_number/x371413321323331 |throughput |[146152031.311op/s; 146173252.558op/s] or [-0.007%; +0.007%]|None |None |None | |credit_card/is_card_number_no_luhn/ |execution_time|[4.632µs; 4.633µs] or [-0.013%; +0.013%] |None |None |None | |credit_card/is_card_number_no_luhn/ |throughput |[215835401.226op/s; 215891037.215op/s] or [-0.013%; +0.013%]|None |None |None | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |execution_time|[73.580µs; 73.637µs] or [-0.038%; +0.038%] |None |None |None | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |throughput |[13580244.437op/s; 13590654.051op/s] or [-0.038%; +0.038%] |None |None |None | |credit_card/is_card_number_no_luhn/ 378282246310005 |execution_time|[65.071µs; 65.131µs] or [-0.046%; +0.046%] |None |None |None | |credit_card/is_card_number_no_luhn/ 378282246310005 |throughput |[15353922.741op/s; 15367942.241op/s] or [-0.046%; +0.046%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631 |execution_time|[4.633µs; 4.634µs] or [-0.011%; +0.011%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631 |throughput |[215817693.673op/s; 215865474.628op/s] or [-0.011%; +0.011%]|None |None |None | |credit_card/is_card_number_no_luhn/378282246310005 |execution_time|[63.567µs; 63.591µs] or [-0.019%; +0.019%] |None |None |None | |credit_card/is_card_number_no_luhn/378282246310005 |throughput |[15725540.137op/s; 15731489.419op/s] or [-0.019%; +0.019%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631000521389798|execution_time|[59.194µs; 59.226µs] or [-0.027%; +0.027%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631000521389798|throughput |[16884510.821op/s; 16893759.778op/s] or [-0.027%; +0.027%] |None |None |None | |credit_card/is_card_number_no_luhn/x371413321323331 |execution_time|[6.840µs; 6.842µs] or [-0.011%; +0.011%] |None |None |None | |credit_card/is_card_number_no_luhn/x371413321323331 |throughput |[146166689.522op/s; 146197664.959op/s] or [-0.011%; +0.011%]|None |None |None | ### Group 5 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |sql/obfuscate_sql_string|execution_time|69.518µs|69.698µs ± 0.145µs|69.680µs ± 0.041µs|69.723µs|69.819µs|70.147µs|71.264µs|2.27% |6.930 |67.327 |0.21%|0.010µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |sql/obfuscate_sql_string|execution_time|[69.678µs; 69.718µs] or [-0.029%; +0.029%]|None |None |None | ### Group 6 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------|--------------|---------|-------------------|-------------------|---------|---------|---------|---------|--------------------|--------|--------|-----|-------|----|-----------| |benching string interning on wordpress profile|execution_time|137.486µs|137.990µs ± 0.368µs|137.942µs ± 0.128µs|138.069µs|138.431µs|139.222µs|141.179µs|2.35% |4.236 |29.571 |0.27%|0.026µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------|--------------|--------------------------------------------|-------------------|------------------------|---------------| |benching string interning on wordpress profile|execution_time|[137.939µs; 138.041µs] or [-0.037%; +0.037%]|None |None |None | ### Group 7 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |--------------------|--------------|-------|-----------------|-----------------|-------|-------|--------|--------|--------------------|--------|--------|------|-------|----|-----------| |write only interface|execution_time|1.417µs|3.332µs ± 1.476µs|3.173µs ± 0.028µs|3.197µs|3.288µs|14.527µs|15.589µs|391.36% |7.575 |57.546 |44.18%|0.104µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |--------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |write only interface|execution_time|[3.127µs; 3.536µs] or [-6.139%; +6.139%]|None |None |None | ### Group 8 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |--------------------------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |concentrator/add_spans_to_concentrator|execution_time|9.148ms|9.188ms ± 0.016ms|9.187ms ± 0.010ms|9.197ms|9.213ms|9.226ms|9.281ms|1.02% |1.234 |5.367 |0.17%|0.001ms|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |--------------------------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |concentrator/add_spans_to_concentrator|execution_time|[9.185ms; 9.190ms] or [-0.024%; +0.024%]|None |None |None | ### Group 9 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------|--------------|---------|--------------------|-------------------|---------|---------|---------|---------|--------------------|--------|--------|-----|-------|----|-----------| |normalization/normalize_trace/test_trace|execution_time|298.430ns|310.614ns ± 13.913ns|304.585ns ± 4.590ns|317.895ns|337.650ns|353.437ns|362.252ns|18.93% |1.536 |1.813 |4.47%|0.984ns|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------|--------------|--------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_trace/test_trace|execution_time|[308.686ns; 312.543ns] or [-0.621%; +0.621%]|None |None |None | ### Group 10 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-----------------|--------------|--------|-------------------|------------------|--------|--------|--------|---------|--------------------|--------|--------|------|-------|----|-----------| |two way interface|execution_time|18.791µs|24.914µs ± 14.008µs|18.926µs ± 0.055µs|21.067µs|46.552µs|58.598µs|153.028µs|708.58% |4.883 |36.341 |56.08%|0.991µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-----------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |two way interface|execution_time|[22.973µs; 26.856µs] or [-7.792%; +7.792%]|None |None |None | ### Group 11 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------------------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |benching deserializing traces from msgpack to their internal representation |execution_time|59.159ms|59.539ms ± 0.211ms|59.559ms ± 0.066ms|59.610ms|59.843ms|60.271ms|60.641ms|1.82% |1.404 |5.441 |0.35%|0.015ms|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------------------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |benching deserializing traces from msgpack to their internal representation |execution_time|[59.509ms; 59.568ms] or [-0.049%; +0.049%]|None |None |None | ### Group 12 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|---------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|398a63d8 |1732553767 |gleocadie/fix-bug-in-crashtracker| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-------------------------------------------------------------------------------------------------------|--------------|----------------|--------------------------------|--------------------------------|----------------|----------------|----------------|----------------|--------------------|--------|--------|-----|------------|----|-----------| |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|execution_time|620.220µs |621.053µs ± 0.650µs |620.990µs ± 0.190µs |621.204µs |621.559µs |621.798µs |629.149µs |1.31% |9.749 |118.702 |0.10%|0.046µs |1 |200 | |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|throughput |1589447.762op/s |1610169.418op/s ± 1668.482op/s |1610332.754op/s ± 493.459op/s |1610797.455op/s |1611453.291op/s |1611889.858op/s |1612330.068op/s |0.12% |-9.668 |117.365 |0.10%|117.979op/s |1 |200 | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |execution_time|466.378µs |466.980µs ± 0.265µs |466.968µs ± 0.165µs |467.139µs |467.461µs |467.714µs |467.844µs |0.19% |0.423 |0.223 |0.06%|0.019µs |1 |200 | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |throughput |2137465.346op/s |2141419.956op/s ± 1214.257op/s |2141473.880op/s ± 754.890op/s |2142198.578op/s |2143188.777op/s |2143880.032op/s |2144185.167op/s |0.13% |-0.419 |0.218 |0.06%|85.861op/s |1 |200 | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |execution_time|191.222µs |191.752µs ± 0.192µs |191.727µs ± 0.119µs |191.882µs |192.121µs |192.194µs |192.256µs |0.28% |0.328 |-0.211 |0.10%|0.014µs |1 |200 | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |throughput |5201393.974op/s |5215078.669op/s ± 5206.634op/s |5215759.940op/s ± 3237.306op/s |5218554.396op/s |5222537.233op/s |5224653.174op/s |5229521.696op/s |0.26% |-0.322 |-0.213 |0.10%|368.165op/s |1 |200 | |normalization/normalize_service/normalize_service/[empty string] |execution_time|47.353µs |47.693µs ± 0.125µs |47.682µs ± 0.070µs |47.753µs |47.932µs |48.005µs |48.047µs |0.77% |0.392 |0.195 |0.26%|0.009µs |1 |200 | |normalization/normalize_service/normalize_service/[empty string] |throughput |20812746.547op/s|20967391.568op/s ± 54913.242op/s|20972359.836op/s ± 30628.218op/s|21001638.388op/s|21052321.030op/s|21070103.962op/s|21117983.048op/s|0.69% |-0.375 |0.183 |0.26%|3882.953op/s|1 |200 | |normalization/normalize_service/normalize_service/test_ASCII |execution_time|51.613µs |51.943µs ± 0.129µs |51.945µs ± 0.067µs |52.009µs |52.153µs |52.263µs |52.300µs |0.68% |-0.040 |0.293 |0.25%|0.009µs |1 |200 | |normalization/normalize_service/normalize_service/test_ASCII |throughput |19120316.956op/s|19251877.371op/s ± 47726.832op/s|19251268.349op/s ± 24797.455op/s|19276055.969op/s|19338120.526op/s|19369367.357op/s|19374897.427op/s|0.64% |0.057 |0.289 |0.25%|3374.797op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-------------------------------------------------------------------------------------------------------|--------------|----------------------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|execution_time|[620.963µs; 621.143µs] or [-0.015%; +0.015%] |None |None |None | |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|throughput |[1609938.183op/s; 1610400.654op/s] or [-0.014%; +0.014%] |None |None |None | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |execution_time|[466.943µs; 467.017µs] or [-0.008%; +0.008%] |None |None |None | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |throughput |[2141251.672op/s; 2141588.241op/s] or [-0.008%; +0.008%] |None |None |None | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |execution_time|[191.725µs; 191.778µs] or [-0.014%; +0.014%] |None |None |None | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |throughput |[5214357.080op/s; 5215800.259op/s] or [-0.014%; +0.014%] |None |None |None | |normalization/normalize_service/normalize_service/[empty string] |execution_time|[47.676µs; 47.711µs] or [-0.036%; +0.036%] |None |None |None | |normalization/normalize_service/normalize_service/[empty string] |throughput |[20959781.121op/s; 20975002.015op/s] or [-0.036%; +0.036%]|None |None |None | |normalization/normalize_service/normalize_service/test_ASCII |execution_time|[51.925µs; 51.961µs] or [-0.034%; +0.034%] |None |None |None | |normalization/normalize_service/normalize_service/test_ASCII |throughput |[19245262.891op/s; 19258491.851op/s] or [-0.034%; +0.034%]|None |None |None |

Baseline

Omitted due to size.

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (25079f5) to head (398a63d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #756 +/- ## ======================================= Coverage 70.51% 70.52% ======================================= Files 297 297 Lines 43385 43401 +16 ======================================= + Hits 30595 30609 +14 - Misses 12790 12792 +2 ``` | [Components](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [crashtracker](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `43.61% <0.00%> (-0.22%)` | :arrow_down: | | [crashtracker-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `8.41% <0.00%> (-0.27%)` | :arrow_down: | | [datadog-alloc](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `98.73% <ø> (ø)` | | | [data-pipeline](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `89.09% <ø> (ø)` | | | [data-pipeline-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [ddcommon](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `83.46% <ø> (ø)` | | | [ddcommon-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.12% <ø> (ø)` | | | [ddtelemetry](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `59.05% <ø> (ø)` | | | [ddtelemetry-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `22.13% <ø> (ø)` | | | [dogstatsd](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `89.45% <ø> (ø)` | | | [dogstatsd-client](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `79.77% <ø> (ø)` | | | [ipc](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.76% <ø> (ø)` | | | [profiling](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `84.30% <ø> (ø)` | | | [profiling-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `77.46% <ø> (ø)` | | | [serverless](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [sidecar](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `38.01% <ø> (ø)` | | | [sidecar-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [spawn-worker](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `50.36% <ø> (ø)` | | | [tinybytes](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `94.77% <ø> (ø)` | | | [trace-mini-agent](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `72.36% <ø> (ø)` | | | [trace-normalization](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `98.23% <ø> (ø)` | | | [trace-obfuscation](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `95.77% <ø> (ø)` | | | [trace-protobuf](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `77.67% <ø> (ø)` | | | [trace-utils](https://app.codecov.io/gh/DataDog/libdatadog/pull/756/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `93.29% <ø> (ø)` | |

🚨 Try these New Features: