DataDog / libdatadog

Datadog shared rust-based library. For now only used in other products (e.g. Ruby or PHP libraries).
Apache License 2.0
48 stars 9 forks source link

feature: ddcommon-net2 crate #766

Open morrisonlevi opened 14 hours ago

morrisonlevi commented 14 hours ago

What does this PR do?

This adds the ddcommon-net2 crate which uses hyper 1, unlike ddcommon-net1 which uses hyper 0.14. The datadog-profiling and datadog-profiling-ffi crates are moved to use ddcommon-net2.

Motivation

Hyper migration.

Additional Notes

I was hoping that this specific implementation strategy would get rid of a specific linking issue I hit on Windows in another PR. However, ddcommon-ffi depends on ddcommon-net1 so both net crates are in play. The relationships are a bit different (better, IMO) but it didn't outright fix the issue. I think all crates built together on Windows need to have the same hyper version dependency :'(

How to test the change?

Describe here in detail how the change can be validated.