search

DataDog / libddprof

libddprof has been renamed to libdatadog and development has moved to https://github.com/datadog/libdatadog
Apache License 2.0
3 stars 2 forks source link

[FEATURE] ddprof-profiles should compress profiles as it serializes them #21

Open ivoanjo opened 2 years ago

ivoanjo commented 2 years ago

Is your feature request related to a problem? Please describe. Currently, to report compressed profiles, the caller needs to manually compress the pprof data that is generated by ddprof-profiles before calling the exporter to report this data back to the backend.

Describe the goal of the feature By having ddprof-profiles compress the data, the caller would no longer need to take care of this, and as a bonus side-effect memory usage during serialization would be reduced.

Describe alternatives you've considered We could have the ddprof-exporter take care of the compression, but that means increased memory usage (because we would still need to hold the uncompressed pprof in memory).

ivoanjo commented 2 years ago

Addendum: I initially specified gzip, but we probably should look into lz4 instead to minimize the cpu impact on the app being profiled.