DataDog / nginx-datadog

Enhance NGINX Observability and Security with Datadog's Module
https://www.datadoghq.com
Apache License 2.0
23 stars 10 forks source link

Error: Executing invalid Datadog script #94

Closed kevinneufeld closed 4 months ago

kevinneufeld commented 4 months ago

After updating to the version 1.2.x without appsec support we are seeing the following nginx errors in our logs:

2024/06/27 18:16:19 [error] 33#33: *2 Executing invalid Datadog script, client: 192.168.65.1, server: localhost, request: "GET / HTTP/1.1", host: "localhost:8080"
2024/06/27 18:16:19 [error] 33#33: *2 Executing invalid Datadog script, client: 192.168.65.1, server: localhost, request: "GET / HTTP/1.1", host: "localhost:8080"
2024/06/27 18:16:19 [error] 33#33: *2 Executing invalid Datadog script while logging request, client: 192.168.65.1, server: localhost, request: "GET / HTTP/1.1", host: "localhost:8080"

Logs and APM traces are published in the Datadog dashboard, but the fact that these errors occur for each request is a bit concerning. Is there a new Datadog module setting we need to set?

When we revert back to v1.1.0 these errors are NOT present.

Tech Specifications: Alpine Linux amd64:v3.20.0 nginx: v1.2.1 nginx-datadog module: v1.2.x

dmehala commented 4 months ago

Hey @kevinneufeld

Thank you for reporting the issue. We are aware of this issue and are working on a fix. Fortunately it is not harmful and don't prevent tracing.

kevinneufeld commented 4 months ago

Hey @dmehala, What is the ETA for getting a fixed release?

dmehala commented 4 months ago

Since the issue does not prevent tracing or appsec, there is no urgency to release a new version solely for this fix. The next release will follow our regular release cycle, which will likely occur in the coming months.

afares-hims commented 1 month ago

Any idea when is the next release? This is a blocker for us to add this module. Thanks!

dmehala commented 1 month ago

Tomorrow @afares-hims

dmehala commented 1 month ago

I encountered build issues for some version of NGINX, unfortunately it will not be today @afares-hims. I am working on fixing the issue this week.

afares-hims commented 1 month ago

No worries, thanks for the heads up!

dmehala commented 1 month ago

New release @afares-hims . Feel free to reach if there's any issue.

afares-hims commented 1 month ago

Thank you @dmehala! appreciate it.