search

DataDog / node-connect-datadog

[DEPRECATED] Datadog middleware for Connect JS / Express
MIT License
15 stars 25 forks source link

Ability to create route specific tags #18

Open nicgirault opened 4 years ago

nicgirault commented 4 years ago

With connect-datadog 0.0.9 it is not possible to add route specific tags. I would like to do so to associate routes to a SLO domain with a tag: domain:my-domain.

I don't see an elegant way to do so. One way would be to adjust this line to read tags that could have been added in middlewares defined after datadog middleware:

let statTags = [...tags, ...req.ddTags]

Would you merge such a PR?

hybby commented 4 years ago

Very interested in the feature proposed by #19 - could someone from Datadog confirm if there's any scope to merge this soon?