search

DataDog / opentelemetry-mapping-go

Go modules that implement OpenTelemetry-to-Datadog mapping for all telemetry signals
Apache License 2.0
13 stars 6 forks source link

Update mappings for OTEL jvm metrics #226

Open lenin-jaganathan opened 6 months ago

lenin-jaganathan commented 6 months ago

https://github.com/DataDog/opentelemetry-mapping-go/blob/5bac6caf49b03562459a115cdbef14be543cdcca/pkg/otlp/metrics/runtime_metric_mappings.go#L92-L224

OTEL Semantic conventions have renamed a lot of JVM metrics and lot of them were made stable as well. DataDog's translator still seem to use the old conventions and applications on new version of OTEL Semconv are missing the built-in dashboards due to this.

lenin-jaganathan commented 6 months ago

On a side note, renaming the OTEL semantic convention metrics to datadog-specific attributes seems to cause a lot of confusion among the users. Is there any discussion to not rename these metrics but still keep the capabilities like built-in dashboards that can support both DD Agent generated metrics and OTEL Semantic convention metrics? This will at least keep the original metric names as is and will help users plotting these metrics.

lenin-jaganathan commented 5 days ago

The mappings are updated via https://github.com/DataDog/opentelemetry-mapping-go/pull/265.

But I would like to get an answer for

Is there any discussion to not rename these metrics but still keep the capabilities like built-in dashboards that can support both DD Agent generated metrics and OTEL Semantic convention metrics?