Closed nsrip-dd closed 1 month ago
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 61.50%. Comparing base (
6bf164e
) to head (03d085e
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
main.go | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What does this PR do?
If the log level is set via
--log-level
, set the corresponding environment variables so that the child processes will get it. This was done for--log-file
already, but only if it was originally a relative path. Propagate it always.Motivation
I noticed this when investigating #223. I was setting the log level to "trace" via the command line and didn't see much output. It took me a bit to realize that the setting wasn't picked up by all the workers. I set the env var instead, but ideally the command line argument works the same way :)
Reviewer's Checklist