search

DataDog / orchestrion

Automatic compile-time instrumentation of Go code
http://datadoghq.dev/orchestrion/
Apache License 2.0
159 stars 5 forks source link

chore: improve CodeCov configuration #247

Closed RomainMuller closed 1 month ago

RomainMuller commented 2 months ago

Upload all reports to CodeCov at once at the end of the validation workflow, so that it stops producing mid-flight coverage reports that don't account for the entire set of reports.

Also, configure coverage collection during integration test execution.

Noticed the linter configuration was outdated and largely inert, so I fixed it up and applied A TON of linter fixes. The rule set is obviously subject to discussion & may also be updated in the future.

eliottness commented 1 month ago

Cannot merge because the changes made in the workflows make the Complete job fail in the merge_group CI because it does not take into account the new jobs that are skipped

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 78.77095% with 76 lines in your changes missing coverage. Please review.

Project coverage is 73.27%. Comparing base (b4de369) to head (f2464a7). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
main.go 8.33% 22 Missing :warning:
internal/injector/aspect/join/function.go 73.52% 9 Missing :warning:
_integration-tests/tests/ibm_sarama/ibm_sarama.go 57.89% 6 Missing and 2 partials :warning:
internal/jobserver/client/env.go 63.15% 4 Missing and 3 partials :warning:
internal/log/log.go 14.28% 6 Missing :warning:
internal/pin/pin.go 81.81% 3 Missing and 1 partial :warning:
_integration-tests/tests/net_http/net_http.go 50.00% 3 Missing :warning:
...ternal/injector/aspect/advice/code/dot_function.go 50.00% 3 Missing :warning:
internal/cmd/server.go 60.00% 0 Missing and 2 partials :warning:
internal/filelock/filelock.go 66.66% 0 Missing and 2 partials :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #247 +/- ## =========================================== + Coverage 62.26% 73.27% +11.01% =========================================== Files 102 140 +38 Lines 5359 7511 +2152 =========================================== + Hits 3337 5504 +2167 + Misses 1680 1587 -93 - Partials 342 420 +78 ``` | [Components](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [Generators](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `67.64% <50.00%> (-1.22%)` | :arrow_down: | | [Instruments](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `88.05% <100.00%> (+53.49%)` | :arrow_up: | | [Go Driver](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `72.81% <100.00%> (+9.89%)` | :arrow_up: | | [Toolexec Driver](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `66.56% <100.00%> (ø)` | | | [Aspects](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `71.79% <90.00%> (+1.80%)` | :arrow_up: | | [Injector](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.24% <90.27%> (+1.62%)` | :arrow_up: | | [Job Server](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `67.27% <77.77%> (+5.72%)` | :arrow_up: | | [Integration Test Suite](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `85.42% <83.33%> (+51.17%)` | :arrow_up: | | [Other](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.27% <78.77%> (+11.01%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [\_integration-tests/gls/access.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Fgls%2Faccess.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL2dscy9hY2Nlc3MuZ28=) | `100.00% <100.00%> (+72.72%)` | :arrow_up: | | [\_integration-tests/tests/aws.v1/aws.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Faws.v1%2Faws.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2F3cy52MS9hd3MuZ28=) | `94.59% <100.00%> (ø)` | | | [\_integration-tests/tests/aws.v2/new\_config.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Faws.v2%2Fnew_config.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2F3cy52Mi9uZXdfY29uZmlnLmdv) | `100.00% <ø> (ø)` | | | [\_integration-tests/tests/chi.v5/chi.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Fchi.v5%2Fchi.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2NoaS52NS9jaGkuZ28=) | `100.00% <100.00%> (ø)` | | | [\_integration-tests/tests/dd-span/ddspan.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Fdd-span%2Fddspan.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2RkLXNwYW4vZGRzcGFuLmdv) | `100.00% <100.00%> (ø)` | | | [\_integration-tests/tests/dd-span/tag.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Fdd-span%2Ftag.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2RkLXNwYW4vdGFnLmdv) | `100.00% <100.00%> (ø)` | | | [\_integration-tests/tests/echo.v4/echo.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Fecho.v4%2Fecho.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2VjaG8udjQvZWNoby5nbw==) | `100.00% <100.00%> (ø)` | | | [\_integration-tests/tests/fiber.v2/fiber.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Ffiber.v2%2Ffiber.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2ZpYmVyLnYyL2ZpYmVyLmdv) | `100.00% <100.00%> (ø)` | | | [\_integration-tests/tests/gin/gin.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Fgin%2Fgin.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2dpbi9naW4uZ28=) | `100.00% <100.00%> (ø)` | | | [\_integration-tests/tests/gorm.jinzhu/gorm.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree&filepath=_integration-tests%2Ftests%2Fgorm.jinzhu%2Fgorm.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-X2ludGVncmF0aW9uLXRlc3RzL3Rlc3RzL2dvcm0uamluemh1L2dvcm0uZ28=) | `100.00% <ø> (ø)` | | | ... and [60 more](https://app.codecov.io/gh/DataDog/orchestrion/pull/247?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/orchestrion/pull/247/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)