Closed rarguelloF closed 1 month ago
Attention: Patch coverage is 98.30508%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 73.82%. Comparing base (
1b1f5aa
) to head (d2cd3f9
). Report is 8 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
_integration-tests/validator/trace/diff.go | 84.00% | 2 Missing and 2 partials :warning: |
Summary of changes:
-v
flag for tests in the CI: this makes the output extremely verbose which is rarely useful, since the default behavior is to show the verbose output for failed tests only, which is what you are usually interested on.trace.Span
->trace.Trace
: this should make naming a little less confusing (nowExpectedTraces
returnstrace.Traces
instead oftrace.Spans
). Clarified in the comment thattrace.Trace
represents the root span of a trace.Meta
tomap[string]string
Metrics
and display in a similar way asMeta
in the tree.mockAgent.NewSession
now runst.Cleanup
for proper test cleanup, so thedefer checkTraces
call is no longer necessary - I was finding the output of the traces not found assertion not helpful while working on the actual test to work.