search

DataDog / orchestrion

Automatic compile-time instrumentation of Go code
http://datadoghq.dev/orchestrion/
Apache License 2.0
159 stars 5 forks source link

chore: allow validation to run for ALL commits on push #314

Closed RomainMuller closed 1 month ago

RomainMuller commented 1 month ago

The concurrency group naming results in cancelling concurrent executions on the same ref on all events, which means individual commits pushed to main may not be fully validated. In particular, this results in missing coverage information & benchmarking results.

Changed the naming so that on push events, the commit SHA is used instead of the commit ref, allowing individual commits to run independently from each other.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.91%. Comparing base (8be22e9) to head (838ebb1). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #314 +/- ## ======================================= Coverage 73.91% 73.91% ======================================= Files 146 146 Lines 7959 7959 ======================================= Hits 5883 5883 Misses 1639 1639 Partials 437 437 ``` | [Components](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [Generators](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `76.98% <ø> (ø)` | | | [Instruments](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `88.05% <ø> (ø)` | | | [Go Driver](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `72.81% <ø> (ø)` | | | [Toolexec Driver](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `70.88% <ø> (ø)` | | | [Aspects](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `70.88% <ø> (ø)` | | | [Injector](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.12% <ø> (ø)` | | | [Job Server](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `63.72% <ø> (ø)` | | | [Integration Test Suite](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `87.75% <ø> (ø)` | | | [Other](https://app.codecov.io/gh/DataDog/orchestrion/pull/314/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.91% <ø> (ø)` | |