search

DataDog / orchestrion

Automatic compile-time instrumentation of Go code
http://datadoghq.dev/orchestrion/
Apache License 2.0
159 stars 5 forks source link

fix(injector): nil-dereference on a specific import order #315

Closed eliottness closed 1 month ago

eliottness commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.92%. Comparing base (b1593a1) to head (65f123e). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/imports.go 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #315 +/- ## ========================================== - Coverage 73.99% 73.92% -0.08% ========================================== Files 145 146 +1 Lines 7811 7966 +155 ========================================== + Hits 5780 5889 +109 - Misses 1596 1640 +44 - Partials 435 437 +2 ``` | [Components](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [Generators](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `76.98% <ø> (ø)` | | | [Instruments](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `88.05% <ø> (ø)` | | | [Go Driver](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `72.81% <ø> (ø)` | | | [Toolexec Driver](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `70.88% <ø> (ø)` | | | [Aspects](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `70.88% <ø> (-0.99%)` | :arrow_down: | | [Injector](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.15% <94.44%> (-0.57%)` | :arrow_down: | | [Job Server](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `63.72% <ø> (ø)` | | | [Integration Test Suite](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `87.75% <ø> (-0.08%)` | :arrow_down: | | [Other](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.92% <94.44%> (-0.08%)` | :arrow_down: | | [Files with missing lines](https://app.codecov.io/gh/DataDog/orchestrion/pull/315?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [internal/injector/injector.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/315?src=pr&el=tree&filepath=internal%2Finjector%2Finjector.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-aW50ZXJuYWwvaW5qZWN0b3IvaW5qZWN0b3IuZ28=) | `73.52% <100.00%> (+1.22%)` | :arrow_up: | | [internal/injector/write.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/315?src=pr&el=tree&filepath=internal%2Finjector%2Fwrite.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-aW50ZXJuYWwvaW5qZWN0b3Ivd3JpdGUuZ28=) | `46.42% <100.00%> (+1.98%)` | :arrow_up: | | [internal/injector/imports.go](https://app.codecov.io/gh/DataDog/orchestrion/pull/315?src=pr&el=tree&filepath=internal%2Finjector%2Fimports.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-aW50ZXJuYWwvaW5qZWN0b3IvaW1wb3J0cy5nbw==) | `84.41% <92.85%> (-0.10%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/orchestrion/pull/315/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)