search

DataDog / puppet-datadog-agent

Puppet module to install the Datadog agent
Other
52 stars 262 forks source link

GPG key cleanup makes node too chatty #295

Open den-is opened 7 years ago

den-is commented 7 years ago

Hello,

GPG key cleanup makes node to chatty in puppet console. Now node has always status as "changed" In general in puppet console i'm checking real changes like my app git repo pull and not such constant tasks like "key install-> remove" every puppet run, every 30 minutes.

Is it possible to make it key permanent like other repos/modules do have. or at least give us optional parameter which disables such behaviour update_key => false

NoodlesNZ commented 7 years ago

I'm having this problem also. Why do you need to delete the gpg key after every run?

ardrigh commented 7 years ago

All they need to do is put the file in /etc/pki/rpm-gpg/ and stop removing it.

Which is what I have done on our fork.

den-is commented 7 years ago

looks like they are not too responsive. tending to make my own module for simple purposes

truthbk commented 7 years ago

Hi fellas, sorry for the slow response. This totally fell of the radar. We had a very similar issue/PR that attempted to remove one of the GPG keys and it totally slipped through the cracks in our last release. I believe @ardrigh is correct and the right place to drop the key is indeed /etc/pki/rpm-gpg, and just leave it there. I will cook up a PR and make sure it makes it into our next release.

On paper the key was meant to be installed by the rpm --import (dropping it wherever it made most sense in the RH variant), unfortunately we did not pick up the fact that it was chatty in our testing for RHEL/CentOS.