search

DataDog / riot

A Python virtual env builder and command runner
https://ddriot.readthedocs.io/
Apache License 2.0
23 stars 15 forks source link

fix: cap long prefix paths #199

Closed P403n1x87 closed 1 year ago

P403n1x87 commented 1 year ago

This change ensures that riot does not generate prefix paths that are too long and might go beyond the limits imposed by the FS.

Fixes #198.

majorgreys commented 1 year ago

Is it necessary to drop 3.6 support here?

P403n1x87 commented 1 year ago

Is it necessary to drop 3.6 support here?

Not here, I can make another PR for that, but CI couldn't pull 3.6 anymore and I thought it didn't make sense to invest time in trying to fix it for such an old version.

ZStriker19 commented 1 year ago

What's FS?

mabdinur commented 1 year ago

macos-latest 3.6 and ubuntu-latest 3.6 are required actions. Should we remove this check to unblock this PR?

P403n1x87 commented 1 year ago

What's FS?

File System 🙂

P403n1x87 commented 1 year ago

macos-latest 3.6 and ubuntu-latest 3.6 are required actions. Should we remove this check to unblock this PR?

Yes, I think we should. But I would like to drop support for 3.6 in another PR first. I'll try to open it today 🤞