[APR-229] Add named outputs for Saluki events

[rayz]

Context

Currently, a single EventBuffer is used to hold metrics, events, and service checks. We would like each event type to have their own named outputs.

Solution

We use 2 additional EventBuffer for events and service checks, leaving the original event buffer dedicated to metrics.

We also add a new blackhole destination for events and service checks, which we will remove when we have a destination that supports them (next pr #126)

Testing

Should not change anything for metrics. Run make run-dsd-basic-udp and see metrics.

Example for sending service checks

Example for sending events

Blackhole will log that it has received events when sending events/service checks.

[pr-commenter[bot]]

Regression Detector (DogStatsD)

Regression Detector Results

Run ID: 7e5c72b1-46ee-48a4-9819-3822121751cf

Baseline: 7.52.0 Comparison: 7.52.1

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------------------------|--------------------|----------|----------------|-------| | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | +0.04 | [+0.00, +0.07] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | +0.03 | [-0.06, +0.12] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | +0.02 | [+0.01, +0.03] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.00 | [-0.06, +0.07] | | | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | -0.00 | [-0.00, +0.00] | | | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -0.00 | [-0.01, +0.01] | | | ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -0.02 | [-0.06, +0.02] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | -0.02 | [-0.09, +0.05] | | | ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | -1.63 | [-1.83, -1.43] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

[pr-commenter[bot]]

Regression Detector (Saluki)

Regression Detector Results

Run ID: d2ef4c45-62c9-4fce-83aa-6a4f6ad4ca0b

Baseline: bd0892dd881fb0d0e4ab151a02730edec346717b Comparison: b34a3fed46ec8373a8687f8a512035edd93efea4

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	dsd_uds_100mb_3k_contexts_distributions_only	memory utilization	-5.66	[-5.80, -5.53]

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|-------------------------------------------------|--------------------|----------|----------------|-------| | ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | +3.85 | [+0.54, +7.17] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.08 | [-0.20, +0.35] | | | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.04 | [-0.08, +0.16] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | +0.00 | [-0.06, +0.07] | | | ➖ | dsd_uds_50mb_10k_contexts_no_inlining_no_allocs | ingress throughput | +0.00 | [-0.04, +0.05] | | | ➖ | dsd_uds_50mb_10k_contexts_no_inlining | ingress throughput | +0.00 | [-0.01, +0.01] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | -0.00 | [-0.04, +0.04] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.01] | | | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.01 | [-0.13, +0.11] | | | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -0.34 | [-0.44, -0.25] | | | ✅ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | -5.66 | [-5.80, -5.53] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

[pr-commenter[bot]]

Regression Detector Links

Experiment Result Links

experiment	link(s)
dsd_uds_100mb_250k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts_distributions_only	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_10mb_3k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_3k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts_memlimit	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_500mb_3k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_512kb_3k_contexts	[Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining (ADP only)	[Profiling (ADP)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs (ADP only)	[Profiling (ADP)] [SMP Dashboard]