DataDog / saluki

An experimental toolkit for building telemetry data planes in Rust.
Apache License 2.0
13 stars 3 forks source link

[APR-230] Add a new destination to support sending events/service checks to the Datadog platform #165

Closed rayz closed 2 months ago

rayz commented 3 months ago

Context

In order to support sending events and service checks to Datadog, we need a new destination to send them to.

Solution

We create a new destination in saluki-components/src/destinations/datadog_events_service_checks that supports both events and service checks.

Testing

Submit events and service checks. You should now see them show up on the Datadog platform.

Finishes #120

pr-commenter[bot] commented 3 months ago

Regression Detector (DogStatsD)

Regression Detector Results

Run ID: 99a1e021-1480-4f51-a929-abb807285a84

Baseline: 7.52.0 Comparison: 7.52.1

Performance changes are noted in the perf column of each table:

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------------------------|--------------------|----------|----------------|-------| | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.02 | [-0.01, +0.04] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | +0.02 | [-0.06, +0.10] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.00 | [-0.03, +0.04] | | | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | | | ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | +0.00 | [-0.03, +0.03] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | +0.00 | [-0.05, +0.05] | | | ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | -0.00 | [-0.25, +0.24] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.00] | | | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.04 | [-0.07, -0.01] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".
pr-commenter[bot] commented 3 months ago

Regression Detector (Saluki)

Regression Detector Results

Run ID: 222f6062-ed0a-4b6a-84ea-2c3b2aca6fc9

Baseline: 4697a7d886c0a60a4f265d7c30f59ec188596efa Comparison: 29bff9e2195a5327ae36e73e4e2dcf5f1c0639da

Performance changes are noted in the perf column of each table:

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|-------------------------------------------------|--------------------|----------|----------------|-------| | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | +1.13 | [+1.03, +1.23] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.09 | [-0.18, +0.36] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | +0.05 | [-0.30, +0.40] | | | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.02 | [-0.09, +0.13] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | +0.01 | [-0.03, +0.05] | | | ➖ | dsd_uds_50mb_10k_contexts_no_inlining | ingress throughput | +0.00 | [-0.03, +0.04] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | +0.00 | [-0.02, +0.03] | | | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.00 | [-0.22, +0.22] | | | ➖ | dsd_uds_50mb_10k_contexts_no_inlining_no_allocs | ingress throughput | -0.00 | [-0.03, +0.03] | | | ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | -0.28 | [-0.42, -0.14] | | | ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -1.16 | [-4.38, +2.06] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".
pr-commenter[bot] commented 3 months ago

Regression Detector Links

Experiment Result Links

experiment link(s)
dsd_uds_100mb_250k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts_distributions_only [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_10mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts_memlimit [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_500mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_512kb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining (ADP only) [Profiling (ADP)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs (ADP only) [Profiling (ADP)] [SMP Dashboard]