[APR-231] Add support to Datadog Metrics destination for retrying requests.

[rayz]

wip, clone error fixed but new error

error[E0277]: the trait bound hyper_util::client::legacy::Error: From<Infallible> is not satisfied
   --> lib/saluki-components/src/destinations/datadog_metrics/mod.rs:272:13
    |
272 |             service,
    |             ^^^^^^^ the trait From<Infallible> is not implemented for hyper_util::client::legacy::Error, which is required by tower::timeout::Timeout<Retry<MetricsRetryPolicy, HttpClient<HttpsConnector<HttpConnector>, _>>>: tower::Service<http::Request<ReplayBody<ChunkedBuffer<_>>>>
    |
    = help: the trait tower::Service<Request> is implemented for tower::timeout::Timeout<S>
    = note: required for Infallible to implement Into<hyper_util::client::legacy::Error>
    = note: required for ReplayBody<ChunkedBuffer<_>> to implement Body
    = note: required for HttpClient<HttpsConnector<HttpConnector>, ReplayBody<ChunkedBuffer<_>>> to implement tower::Service<http::Request<ReplayBody<ChunkedBuffer<_>>>>

error persists even after adding ReplayBody.

TODOs: add license from copying ReplayBody code from linkerd

[pr-commenter[bot]]

Regression Detector (DogStatsD)

Regression Detector Results

Run ID: 89db938e-23a7-4d90-a395-1257476bc8bf

Baseline: 7.52.0 Comparison: 7.52.1

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------------------------|--------------------|----------|----------------|-------| | ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | +0.84 | [+0.63, +1.05] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | +0.02 | [-0.05, +0.09] | | | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -0.00 | [-0.00, +0.00] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | -0.00 | [-0.01, +0.01] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | -0.00 | [-0.06, +0.05] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | -0.02 | [-0.07, +0.04] | | | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.02 | [-0.05, +0.01] | | | ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -0.02 | [-0.06, +0.03] | | | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | -0.05 | [-0.08, -0.02] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

[tobz]

Superceded by #241.