search

DataDog / saluki

An experimental toolkit for building telemetry data planes in Rust.
Apache License 2.0
12 stars 2 forks source link

fix: change default aggregation window from 10 seconds to 15 seconds #210

Closed tobz closed 3 weeks ago

tobz commented 3 weeks ago

Context

I screwed up when I made the default aggregation window be 10 seconds. It's 15 seconds in the Datadog Agent.

That's it. That's the PR.

pr-commenter[bot] commented 3 weeks ago

Regression Detector (Saluki)

Regression Detector Results

Run ID: 2429776d-9478-4d0c-bea4-ceb25af2440e

Baseline: 3b9013668b0cc916a170de1dcf5dc7e489d93551 Comparison: 42c08ea735ea5c584b2c9408ebfff818b760e418

Performance changes are noted in the perf column of each table:

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI links
❌ dsd_uds_1mb_50k_contexts_memlimit ingress throughput -8.62 [-11.71, -5.52]

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|-------------------------------------------------|--------------------|----------|-----------------|-------| | ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | +3.75 | [+3.60, +3.91] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | +0.02 | [-0.19, +0.23] | | | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.00 | [-0.05, +0.05] | | | ➖ | dsd_uds_50mb_10k_contexts_no_inlining | ingress throughput | +0.00 | [-0.03, +0.03] | | | ➖ | dsd_uds_50mb_10k_contexts_no_inlining_no_allocs | ingress throughput | -0.01 | [-0.06, +0.05] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.00] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | -0.02 | [-0.19, +0.16] | | | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.03 | [-0.18, +0.13] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | -0.06 | [-0.34, +0.21] | | | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -0.56 | [-0.66, -0.47] | | | ❌ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -8.62 | [-11.71, -5.52] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".
pr-commenter[bot] commented 3 weeks ago

Regression Detector (DogStatsD)

Regression Detector Results

Run ID: c489c2cb-c570-48e1-8f48-9eee0470fb2f

Baseline: 7.52.0 Comparison: 7.52.1

Performance changes are noted in the perf column of each table:

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|----------------------------------------------|--------------------|----------|----------------|-------| | ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | +0.01 | [-0.03, +0.05] | | | ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | +0.01 | [-0.00, +0.02] | | | ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | | | ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | | | ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -0.00 | [-0.00, +0.00] | | | ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -0.02 | [-0.04, +0.01] | | | ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | -0.03 | [-0.10, +0.04] | | | ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | -0.04 | [-0.12, +0.05] | | | ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | -2.40 | [-2.64, -2.17] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".
pr-commenter[bot] commented 3 weeks ago

Regression Detector Links

Experiment Result Links

experiment link(s)
dsd_uds_100mb_250k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts_distributions_only [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_10mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts_memlimit [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_500mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_512kb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining (ADP only) [Profiling (ADP)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs (ADP only) [Profiling (ADP)] [SMP Dashboard]