pr-commenter[bot]
commented
3 weeks ago Regression Detector (DogStatsD)
Regression Detector Results
Run ID: d49a3418-6a47-4e2a-8f9d-cc13ff16ad1d
Baseline: 7.52.0 Comparison: 7.52.1
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Context
In #210, we attempted to "fix" our observed issues with the amount of output data from ADP not matching DSD by changing the bucket width (window duration) from 10 seconds to 15 seconds. This did fix the output data discrepancy, but still wasn't actually correct.
In the Datadog Agent, the bucket width is in fact 10 seconds, while the flush interval is 15 seconds.
Solution
This PR introduces a standalone setting for flush interval -- defaulting to 15 seconds -- to bring this up to snuff. We had to rework a bit of the flush logic to properly account for zero-value counters when we may be flushing multiple buckets, but overall things are a bit simpler (I think, at least) and hopefully easier to understand.
There's still some temporary data structures we use to track our progress and so on, and maybe we can optimize or eliminate needing them in the future... but for now, things work.