DataDog / serilog-sinks-datadog-logs

Serilog Sink that sends log events to Datadog https://www.datadoghq.com/
Apache License 2.0
60 stars 41 forks source link

Retry Option Not Working in 0.5.2 #116

Open rhdehf1030 opened 1 month ago

rhdehf1030 commented 1 month ago

Hello, I recently updated to version 0.5.2 of the DatadogSink package, expecting the Retry Option to be available as per the commit notes. However, upon attempting to implement the feature, I found that the MaxRetries option does not exist in the current version.

Below is a sample code snippet illustrating the issue:

using DatadogSink datadogSink = new(
   apiKey,
   source,
   service,
   host,
   tags,
   configuration,
   exceptionHandler: (ex) =>
   {
       failedMessages.Add(ex.Message);
   }
);

DatadogConfiguration datadogConfiguration = new()
{
    Url = "blah",
    UseSSL = true,
    MaxRetries = 100 // Not Exists
};

I referred to the commit below

https://github.com/DataDog/serilog-sinks-datadog-logs/compare/v0.5.2...master#diff-a730ab0486a6e0a8cd053be5714674a855c51eeaf29817546d66e1cab6e98faeR51

Could you please check if this release actually includes the retry option?

Thank you for your assistance.

jszwedko commented 1 month ago

HI @rhdehf1030 !

As you discovered, this option isn't available in v0.5.2. The change hasn't yet been released, but will be part of v0.6.0.