Fix missing method exceptionfor461

DataDog / serilog-sinks-datadog-logs

Serilog Sink that sends log events to Datadog https://www.datadoghq.com/

Apache License 2.0

60 stars 42 forks source link

Fix missing method exceptionfor461 #55

Closed ogaca-dd closed 3 years ago

ogaca-dd commented 3 years ago

Fix MissingMethodException when using .NET 4.61 with .NET Standard 2.0

ransagy commented 3 years ago

Does this work in runtime for .NET 4.6.1 targets? AFAIK It should use the NuGet version of System.Net.Http rather than the reference, but it could be that they changed the nuget targetting rules.

ogaca-dd commented 3 years ago

I have done the following tests:

.NET framework 4.6.1 project using directly Serilog.Sinks.Datadog.Logs
.NET framework 4.6.1 project using a .NetStandard 2.0 project that use Serilog.Sinks.Datadog.Logs
Other framework combinations.

Everything looks fine. Let me know if you think there is another combination of framework that can have an issue.

ransagy commented 3 years ago

Oh i'm sure you tested it; I'm just confused as to why it works exactly, but i guess it depends on which of the System.Net.Http API is being used. Either way, all good :)