Closed annerajb closed 1 year ago
We removed this intentionally as it was a breaking some tracer libraries. Is this an issue for you? It should work fine without it.
tracer library may work fine but this page asked for it to be configured is it no longer the case / not required and the documentation incorrect? Which tracer libraries did it affect? https://docs.datadoghq.com/integrations/guide/source-code-integration/?tab=github#configure-repositories
Let me confirm what will break without it, but as of right now it can actually break your tagging.
So I've confirmed that you should not need to add the repository_url to your function. It should just work with the commit sha. I think we could perhaps make the documentation more clear here that it's not required for the serverless use case.
When I go to Integrations -> Link Source Code via the Datadog web app, it still demands "git.repository_url" be tagged on my telemetry -- blocking my ability to complete the APM setup:
I found this same page today and was wondering what was up with this. @IvanTopolcic
can we reopen this?
Expected Behavior
DD_TAGS contains both git.commit.sha and git.repository_url
Actual Behavior
only git.commit.sha is included
Steps to Reproduce the Problem
Specifications
Lambda function runtime (Python 3.7, Node 10, etc.): node 16 (but this is when serverless packages)
Seems this commit removed it https://github.com/DataDog/serverless-plugin-datadog/commit/cea6e9a4e070b821c4ce4823ba8a2046b179ca57#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80L409
in this line the function returns both a remote and a githash but only the githash is used