search

DataDog / serverless-plugin-datadog

Serverless plugin to automagically instrument your Lambda functions with Datadog
Apache License 2.0
96 stars 49 forks source link

git.repository_url was removed and now only git.commit.sha is added to the DD_TAGS #309

Closed annerajb closed 1 year ago

annerajb commented 2 years ago

Expected Behavior

DD_TAGS contains both git.commit.sha and git.repository_url

Actual Behavior

only git.commit.sha is included

Steps to Reproduce the Problem

  1. enable source code integration
  2. (put breakpoints / deploy the lambda) you will see only the hash returned from the datadog-ci library
  3. https://github.com/DataDog/serverless-plugin-datadog/commit/cea6e9a4e070b821c4ce4823ba8a2046b179ca57#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80L409

Specifications

in this line the function returns both a remote and a githash but only the githash is used

IvanTopolcic commented 2 years ago

We removed this intentionally as it was a breaking some tracer libraries. Is this an issue for you? It should work fine without it.

annerajb commented 2 years ago

tracer library may work fine but this page asked for it to be configured is it no longer the case / not required and the documentation incorrect? Which tracer libraries did it affect? https://docs.datadoghq.com/integrations/guide/source-code-integration/?tab=github#configure-repositories

IvanTopolcic commented 1 year ago

Let me confirm what will break without it, but as of right now it can actually break your tagging.

IvanTopolcic commented 1 year ago

So I've confirmed that you should not need to add the repository_url to your function. It should just work with the commit sha. I think we could perhaps make the documentation more clear here that it's not required for the serverless use case.

mccorkle commented 1 year ago

When I go to Integrations -> Link Source Code via the Datadog web app, it still demands "git.repository_url" be tagged on my telemetry -- blocking my ability to complete the APM setup:

Screen Shot 2022-12-12 at 7 47 43 PM

annerajb commented 1 year ago

I found this same page today and was wondering what was up with this. @IvanTopolcic

can we reopen this?