Closed tmadej closed 10 hours ago
Hi @tmadej, thanks a lot for opening this and testing out the patch
IIUC the config.testingMode === false && config.integrationTesting === false
fixes the issue but I think the nested conditional needs a slight tweak to still error if only one of the API key or the app key is present. We would welcome a PR or we can work on one and update you here
Hey @tmadej,
I'm revisiting this, but there has been a couple releases since this issue was created. Is the issue persisting to this day? I'm not sure I understand what might be the issue. Happy to raise a PR to fix the problem. Could you share a reproduction case? Thanks!
Hey @tmadej,
We haven't heard from you in a while – I'm gonna close this as we haven't found a reproduction case for this! Please upgrade to the latest version!
Feel free to re-open if you have any questions, or issue persist.
When trying to deploy with monitors enabled, config.apiKey present & test mode off, I found that this plugin was throwing the below error:
When reviewing the logic for this, I found that the logic is slightly off. I cleaned it up in the below patch and it seems to be working as expected now: