Closed lym953 closed 2 months ago
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove
command.
Use /merge -c
to cancel this operation!
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main
is 2m.
Use /merge -c
to cancel this operation!
What does this PR do?
isSafeToModifyStepFunctionLambdaInvocation()
intoupdateDefinitionForDefaultLambdaApiStep()
, which is the only non-test callerisSafeToModifyStepFunctionLambdaInvocation()
. Add tests forupdateDefinitionString()
to test the deleted test cases.Motivation
isSafeToModifyStepFunctionLambdaInvocation()
only returns a true/false value, but we want to implement multiple instrumentation strategies based on the existing state of Parameters field, so we need to merge the state-checking logic into the caller function.Testing Guidelines
Passed the existing and added tests
Additional Notes
Design doc: Fixing Step Function Instrumentation
Types of changes
Check all that apply