DataDog / serverless-plugin-datadog

Serverless plugin to automagically instrument your Lambda functions with Datadog
Apache License 2.0
96 stars 49 forks source link

chore: Fix message when sfn->Lambda context injection is already set … #536

Closed lym953 closed 1 month ago

lym953 commented 1 month ago

…up using Payload.$

Motivation

If serverless.yml is already setting up sfn->Lambda context injection using the Payload.$ field:

Payload.$: "States.JsonMerge($$, $, false)"

right now our plugin will print a message:

image

This shouldn't be a [Warn]. We usually only add [Warn] when context injection is not set up yet and skipped for some reason.

What does this PR do?

Remove the [Warn]

Testing Guidelines

image

Additional Notes

Types of changes

Check all that apply

lym953 commented 1 month ago

/merge

dd-devflow[bot] commented 1 month ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 2m.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 1 month ago

:rotating_light: MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr. It's probably because:

Details Error: PUT https://api.github.com/repos/DataDog/serverless-plugin-datadog/pulls/536/merge: 405 4 of 4 required status checks are expected. [] FullStacktrace: activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-5f86d7f7c8-jlx2t@): PUT https://api.github.com/repos/DataDog/serverless-plugin-datadog/pulls/536/merge: 405 4 of 4 required status checks are expected. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

lym953 commented 1 month ago

/merge

dd-devflow[bot] commented 1 month ago

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 1 month ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 2m.

Use /merge -c to cancel this operation!