DataDog / serverless-plugin-datadog

Serverless plugin to automagically instrument your Lambda functions with Datadog
Apache License 2.0
96 stars 49 forks source link

Skip sfn->sfn context injection when CONTEXT field exists (case 2) #537

Closed lym953 closed 1 month ago

lym953 commented 1 month ago

What does this PR do?

If the Parameter.Input field has custom CONTEXT, then skip context injection and print a warning. This case should be rare, so we don't support this case for now. We can consider supporting it if a client actually complains.

Motivation

Testing Guidelines

Passed the added test

Additional Notes

See all the cases in the design doc Fixing Step Function Instrumentation

Types of changes

Check all that apply

lym953 commented 1 month ago

/merge

dd-devflow[bot] commented 1 month ago

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 1 month ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 2m.

Use /merge -c to cancel this operation!