Change state machine tag key from DD_XYZ to xyz - Githubissues

DataDog / serverless-plugin-datadog

Serverless plugin to automagically instrument your Lambda functions with Datadog

Apache License 2.0

96 stars 49 forks source link

Change state machine tag key from DD_XYZ to xyz #553

Closed lym953 closed 2 weeks ago

lym953 commented 2 weeks ago

Background

https://github.com/DataDog/serverless-plugin-datadog/pull/552 sets DD_ENV, DD_SERVICE and DD_VERSION tags on the state machines.

Motivation

From the "custom" approach of instrumenting a state machine, we should set env, service and version, not the DD_XXX ones.

What does this PR do?

Makes plugin set env, service and version tags on the state machine instead of the DD_XXX ones.

Testing Guidelines

Passed the touched tests.

Additional Notes

Need a review from Cloud Tracing team, who, as the downstream consumer, should know what tags should be set here.

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

[x] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[x] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

lym953 commented 2 weeks ago

/merge

dd-devflow[bot] commented 2 weeks ago

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-07 22:49:47 UTC :information_source: MergeQueue: pull request added to the queue

The median merge time in main is 2m.