DataDog / stratus-red-team

:cloud: :zap: Granular, Actionable Adversary Emulation for the Cloud
https://stratus-red-team.cloud
Apache License 2.0
1.78k stars 208 forks source link

refactor: remove global variables for all commands #572

Open aymene01 opened 1 week ago

aymene01 commented 1 week ago

What does this PR do?

This PR refactors the detonate_cmd.go file by removing the use of global variables, which improves code maintainability and readability.

Motivation

This is my first contribution to a Datadog repository, and I'm eager to get started on security in the cloud and security in general.

Checklist

christophetd commented 1 week ago

Thanks for the contribution, this makes a lot of sense! Do you know if we have the same problem for other commands? If yes it would make sense to fix it for others as well

aymene01 commented 1 week ago

Thanks for the contribution, this makes a lot of sense! Do you know if we have the same problem for other commands? If yes it would make sense to fix it for others as well

Yes, I see this in other commands. I can refactor them as well

aymene01 commented 1 week ago

Accidentally closed the PR with a misclick 😑, done for all commands you can have a look and give me your feedback :)