DataDog / synthetics-ci-github-action

Use Browser and API tests in your CI/CD with Datadog Continuous Testing
https://docs.datadoghq.com/continuous_testing/
Apache License 2.0
41 stars 14 forks source link

polling_timeout does not seem to get picked up by action #150

Closed juliensanmartin closed 1 year ago

juliensanmartin commented 1 year ago

Hi,

I am using Datadog synthetics action version 0.12.0 and added polling_timeout to my action to increase the timeout from 30 min to 60 min before action fail, in a script like so:

name: Run Datadog Synthetics tests
        uses: DataDog/synthetics-ci-github-action@v0.12.0
        with:
          api_key: ${{secrets.DD_API_KEY}}
          app_key: ${{secrets.DD_APP_KEY}}
          public_ids: 'foo, bar'
          polling_timeout: 3600000

However the action still fails after 30 minutes (see example run below)

Screenshot 2023-05-24 at 4 45 17 PM

did I do something wrong or can it be a bug?

Drarig29 commented 1 year ago

Hi @juliensanmartin! I don't think you did something wrong, it must be a bug. We'll investigate this and fix the issue asap!

Thanks for reporting this.

etnbrd commented 1 year ago

Hey @juliensanmartin 👋 Thanks for your patience, we finally got the time to investigate, we indeed found a bug on our end, and fixed it in the last release: v0.13.0!

Thanks again for submitting this issue, that's very appreciated on our end 🙏 I'm closing this issue. Let us know if it's working on your end as well, and if it's not, feel free to reopen so that we can have a closer look.

juliensanmartin commented 1 year ago

Thanks @etnbrd. Will test the new version asap. Really appreciate the fast turn around 🎉

juliensanmartin commented 1 year ago

Just tested and it's working. Thanks again