DataDog / terraform-provider-datadog

Terraform Datadog provider
https://www.terraform.io/docs/providers/datadog/
Mozilla Public License 2.0
400 stars 376 forks source link

datadog_integration_aws - allow filter_tags for all AWS services #2088

Open ivanmartos opened 1 year ago

ivanmartos commented 1 year ago

What resources or data sources are affected?

datadog_integration_aws

Feature Request

Currently, based on documentation, resource datadog_integration_aws attribute filter_tags works for EC2 service only

https://registry.terraform.io/providers/DataDog/datadog/latest/docs/resources/integration_aws#filter_tags

Can this resource be extended to support all AWS services for functionality of filtering by tags? In DataDog console AWS integration page (under tab Metrics Collection) this option is specific per AWS service

References

No response

waneal commented 1 year ago

Hi, @ivanmartos.

I think datadog_integration_aws_tag_filter can satisfy your requirements.

retskcud commented 9 months ago

I would like to upvote this. It would be good to have "EC2" as part of the options since EC2 is available in the Datadiog integration via the UI.

fatbasstard commented 3 months ago

So as I understand correctly, the following settings from the UI:

image

Map into 2 different resources now? EC2 is configured with datadog_integration_aws, while all the others are part of integration_aws_tag_filter.

Would be nice to have ec2 in the datadog_integration_aws_tag_filter as well and maybe even remove it from the datadog_integration_aws