DataDog / terraform-provider-datadog

Terraform Datadog provider
https://www.terraform.io/docs/providers/datadog/
Mozilla Public License 2.0
403 stars 379 forks source link

[datadog_synthetics_test] Remove `request_definition.timeout` default value #2459

Closed Drarig29 closed 4 months ago

Drarig29 commented 4 months ago

This is a PR stack, here is how it's organized:


In https://github.com/DataDog/terraform-provider-datadog/pull/1497, we added the same value in TF as in the UI to fix a bug where the timeout was set to 0.

But always hardcoding the default value has a side effect: the UI says that 1 option is configured, which isn't exactly right when users do not have a request_definition.timeout set in TF.

image

Our backend now ignores 0 for a timeout, so we can remove the default value from TF and ensure the change is backwards compatible (i.e. doesn't generate diffs when planning/applying)