[datadog_logs_custom_destination] Fix creation failing without forward_tags_restriction_list set

DataDog / terraform-provider-datadog

Terraform Datadog provider

https://www.terraform.io/docs/providers/datadog/

Mozilla Public License 2.0

403 stars 379 forks source link

[datadog_logs_custom_destination] Fix creation failing without forward_tags_restriction_list set #2565

Closed Prepager closed 2 months ago

Prepager commented 2 months ago

Motivation

If you attempt to create a custom destination without the optional forward_tags_restriction_list field. You get the following error: 2024-09-06-at-17 00 03@2x This is caused by the field being marked computed and the IsNull() check allowing through unset computed values causing type conversion issues.

Changes

This PR ensures computed values are checked with IsUnknown() instead of isNull(). A test is also added with only the required fields to ensure this works going forward.

amaskara-dd commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in master is 1m.

Use /merge -c to cancel this operation!