DataDog / watermarkpodautoscaler

Custom controller that extends the Horizontal Pod Autoscaler
Apache License 2.0
211 stars 25 forks source link

Send metrics in dry run edge case #187

Closed khewonc closed 11 months ago

khewonc commented 1 year ago

What does this PR do?

Metrics weren't being set when the WPA was in dry run, replicas were above max or below min replicas, and the controller pod was restarted. The issue could be triggered with these steps:

  1. WPA in dry run
  2. scale app to > max replicas
  3. delete WPA pod

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.