search

DataHaskell / dh-core

Functional data science
138 stars 23 forks source link

Add property tests + bug fix in oneHot #53

Closed Magalame closed 5 years ago

Magalame commented 5 years ago

From #37

There was update cold hot in oneHot that was merging the encoding and the previous array.

I implemented some generators for RFrameUpdate, also some arbitrary classes, but only in Spec.hs. I'm not sure that's the right way to do it though

Magalame commented 5 years ago

Will do!

Magalame commented 5 years ago

It seems like the old fixtures are broken by the use of Strings and Text Edit: nvm, had forgotten an extension

Magalame commented 5 years ago

Oh damn, actually we don't need this import, I had it for debug purposes and forgot to remove it. Same thing for the Show v constraint in the oneHot signature