Speed up sql building by short-circuiting the compilation for CAST(...)

DataJunction / dj

A metrics platform.

http://datajunction.io

MIT License

29 stars 13 forks source link

Speed up sql building by short-circuiting the compilation for CAST(...) #1030

Closed shangyian closed 4 weeks ago

shangyian commented 1 month ago

Summary

We can speed up node SQL building for some cases by short-circuiting the compilation process for CAST(...) expressions, since the type of the expression is clearly determined by what the cast data type is set to.

Test Plan

N/A

[ ] PR has an associated issue: #
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan

N/A

netlify[bot] commented 1 month ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name	Link
Latest commit	e3453baccdf868e41eebdc208952b0e3eadb3d55
Latest deploy log	https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/665abed17df8310008680e2b