DataJunction / dj

A metrics platform.
http://datajunction.io
MIT License
29 stars 13 forks source link

Add column attributes to notebook export #1083

Closed shangyian closed 2 days ago

shangyian commented 2 days ago

Summary

When exporting a node to a notebook, we should also generate client code for setting column attributes on the node. This PR adds that functionality, which gets us to an export that contains a full representation of a node + all its metadata.

An example of the missing client code:

repair_order_details.set_column_attributes(
    "repair_type_id",
    [
        ColumnAttribute(namespace="system", name="dimension"),
    ],
)

Test Plan

Deployment Plan

netlify[bot] commented 2 days ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
Latest commit 382ff3bb97fde432e1eb90519e7f2dbfee587810
Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/668561ceb57633000818ae4f