DataJunction / dj

A metrics platform.
http://datajunction.io
MIT License
35 stars 15 forks source link

Requesting metrics SQL should work for metrics that have different parents #1198

Closed shangyian closed 1 month ago

shangyian commented 1 month ago

Summary

This PR completes the work around requesting metrics SQL so that it still works if we request two metrics that have different parent nodes. In this scenario, we need to build queries for each set of metrics, grouped by their parent nodes, layer in the metric aggregations, and then join on the shared dimension attributes.

This was previously working in the old SQL build, but we didn't fully complete the work in migrating to the v2 build.

Test Plan

Locally

Deployment Plan

ASAP

netlify[bot] commented 1 month ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
Latest commit 20be7c4329ca2fa8d56b6ae1fcf1e3ace1951123
Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/67084a0045f6180008c4415b