The /data endpoints also need to build SQL before they can send off requests to the query service for data. These endpoints should also use the queryrequest cache where possible.
This PR also fixes some additional issues, including
Requiring dimensions when metrics SQL is requested. While we can continue to keep this "at least one dimension" requirement when someone is creating a cube, it should be possible to just request metrics without any dimensions, resulting in a single aggregate value for the metric.
Not filtering out empty dimensions (arguably this is user error, but easier for the server-side to just filter out these rather than raising an error)
Fix a bug with defaulting to name on the foreign key mapping during sql building when this attribute doesn't exist.
Summary
The
/data
endpoints also need to build SQL before they can send off requests to the query service for data. These endpoints should also use thequeryrequest
cache where possible.This PR also fixes some additional issues, including
name
on the foreign key mapping during sql building when this attribute doesn't exist.Test Plan
make check
passesmake test
shows 100% unit test coverageDeployment Plan