DataJunction / dj

A metrics platform.
http://datajunction.io
MIT License
29 stars 13 forks source link

FIX python client error not propagating #985

Closed anhqle closed 1 month ago

anhqle commented 1 month ago

Summary

Current code checks for the existence of response with if exc.response, which is a semantic bug because 400 responses are actually Falsy.

This PR removes this check (since exc.response should always exist anyway), ultimately allowing the error message to be propagated

Test Plan

netlify[bot] commented 1 month ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
Latest commit ce7537bc4be506e495c9c994153ba87076032b76
Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/663bb5c227c9ec0008590e4a
shangyian commented 1 month ago

@anhqle just to check, you have permissions to merge PRs in this repo right?

anhqle commented 1 month ago

I think so, will let you know otherwise