Closed anhqle closed 1 month ago
Name | Link |
---|---|
Latest commit | ce7537bc4be506e495c9c994153ba87076032b76 |
Latest deploy log | https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/663bb5c227c9ec0008590e4a |
@anhqle just to check, you have permissions to merge PRs in this repo right?
I think so, will let you know otherwise
Summary
Current code checks for the existence of response with
if exc.response
, which is a semantic bug because 400 responses are actually Falsy.This PR removes this check (since exc.response should always exist anyway), ultimately allowing the error message to be propagated
Test Plan
make check
passesmake test
shows 100% unit test coverage