DataMascara / cisc3140-su19-project

https://bc-app-class.herokuapp.com/login/
2 stars 5 forks source link

Bad Request Key Error when Hitting Enter While Search Field is Empty #26

Closed LoadingUser3 closed 5 years ago

LoadingUser3 commented 5 years ago

Hitting enter while Search field is empty in the /login/ page results in a Key Error.

Steps to replicate:

  1. Go to Url: 127.0.0.1:8080/login/
  2. Click on the Search field
  3. Hit Enter.

Result: wekzeug.exceptions.BadRequestKeyError

Screenshots: image

image

Extra Notes:

• Error does not show when in the Url is http://127.0.0.1:8080/signup. Instead, it gives a Method Not allowed error.

Maker-Mark commented 5 years ago

Search Functionality has not been implemented yet. We are focusing on the series of new user actions. Please review the Projects board which has issues pinned. Feel free to add some there! I just added the sign-up error testing request.

image image

LoadingUser3 commented 5 years ago

Shifting test focus to user registration/new user actions.

Thank you for informing us.

Maker-Mark commented 5 years ago

Shifting test focus to user registration/new user actions.

Thank you for informing us. Thank you!

mary060196 commented 5 years ago

Hey, @LoadingUser3 and @Maker-Mark ! I want to change one line of code in the base.html so that empty searches would not be submitted. I already have the code, and I just need to paste it into one of the lines. Will this cause issues with the deployment of the application?

mary060196 commented 5 years ago

Hello @Maker-Mark , The base.html template was changed such that an empty search (when it will be implemented) will never be submitted when it is empty. Please check this out by clicking ENTER when there is a focus on the search box (it was added no to much time ago, so please retrieve the lastest template. Thank you very much!

LoadingUser3 commented 5 years ago

No errors when enter is hit while search field is empty!

Fantastic job.

mary060196 commented 5 years ago

Woohoo! Thanks, and good job!