The trending ports does not have 'isSubscribed' value to know if the user is subscribed to it

derickfan commented 5 years ago

In the portIndex.html file it checks if the port['isSubscribed] is True so it'll know whether to show "Subscribe" or "Joined" Screen Shot 2019-08-11 at 7 50 49 PM

However in the base.html file the trending ports does not check for the 'isSubscribed' value so it will always show the user "Subscribe" even if they are already subscribed to it Screen Shot 2019-08-11 at 7 45 17 PM

Screen Shot 2019-08-11 at 7 52 41 PM

mary060196 commented 5 years ago

Good indication! I'll fix this issue once I finish uploading the other templates. Do not close this issue until I fix it. Thank you so much, Derick!

mary060196 commented 5 years ago

Just as a note: the trending ports section should only display 5 trending ports of choice.

derickfan commented 5 years ago

Yea right now we're justing using all the ports since we don't currently have a way of knowing which is trending. Thanks!

mary060196 commented 5 years ago

Thank you!

derickfan commented 5 years ago

Hey upvotes and downvotes in posts.html will most likely need an indicator too if the user already upvoted or downvoted the post

mary060196 commented 5 years ago

Correct! I noticed this issue, and I am currently adding this feature into the postDetails.html template. After I finish this template and upload it, I will fix the posts.html and add this feature there, too. Thank you so much for notifying me about this, Derick!

mary060196 commented 5 years ago

@derickfan , I finished uploading the postDetails.html template and its static files. Now I am about to change the post.html template as follows:

Hide the "Create Post" button if the user is logged out
Add a special argument so that a user can see his or her previous votes (which is what you noticed above,) and
Hide the "++" and "--" buttons if the user is logged out.

Derick, I'll notify you here when this change is made. I have not addressed the trending ports issue yet, so do not close this issue.

Thank you so much!

mary060196 commented 5 years ago

@derickfan , the issue with posts.html was corrected now.

mary060196 commented 5 years ago

@vladislavglad , please re-deploy the app with all the changes made by now. Thank you very much!

vladislavglad commented 5 years ago

@mary060196, I have redeployed the templates, here are the updated links. Note: these are all based on test.py file in the app folder.

Maker-Mark commented 5 years ago

@vladislavglad were you able to get a live version of the app running locally? If so, how comfortable with heroku are you, and is it possible to launch the two servers concurrently(at the same time) in one heroku app? If not, I am thinking to try and deploy the API separately with CI/CD so the live site on heroku would work.

Im going to look into this more today, any advice/feedback is appreciated!

vladislavglad commented 5 years ago

@Maker-Mark, locally I have unresolved import statement: from database import dbmodule in the run.py file, however, I see you already deployed that file!

And about Heroku: I am new to that...

mary060196 commented 5 years ago

@vladislavglad , great thanks for the re-deployment! It is extremely helpful for visualization.

Maker-Mark commented 5 years ago

@vladislavglad , great thanks for the re-deployment! It is extremely helpful for visualization. Live deployed app is at https://bc-app-class.herokuapp.com/

mary060196 commented 5 years ago

Good morning, @derickfan and @Maker-Mark ! The trending ports issues with the subscription buttons were fixed. Now:

The trending ports array of dicts can include an isSubscribed argument that will be caught by the template base.html. What it means: a user can see to which of the trending ports he or she is already subscribed.
The scripts.js file was modified to check for existence of additional buttons with regard to the same port. What it means: if a user presses Subscribe or Joined (to unsubscribe) on the trending ports section, and the user is at the page that renders portIndex.html, the corresponding button on the port index will change accordingly.
The scriptsPortIndex.js file was modified to check for the existence of a button on the trending port section for the same port. What it means: if a user presses Subscribe or Joined (to unsubscribe) on the port index section, and the user is at the page that renders portIndex.html, the corresponding button on the trending ports section will change accordingly.
Since the Subscriptions tab in Dashboard also displays ports, the exact same features above were added for the scriptsUserInfo.js file. In other words, please check if this particular bug was fixed.

Thank you very, very much for your patience!

mary060196 commented 5 years ago

@derickfan , I have made changes to two JavaScript files to correct the issue with the buttons, but re-deployment did not occur. I am using the GitHub GUI, so I do not push with the command line. How can the app be re-deployed? Thank you for this!

mary060196 commented 5 years ago

Issue successfully resolved! Thanks a lot!

DataMascara / cisc3140-su19-project

The trending ports does not have 'isSubscribed' value to know if the user is subscribed to it #28