search

DataMascara / cisc3140-su19-project

https://bc-app-class.herokuapp.com/login/
2 stars 5 forks source link

frontend syntax error #5

Closed AlvinH349 closed 5 years ago

AlvinH349 commented 5 years ago

Hi frontend, I found a problem in your HTML file called base that revolves around the left container and there is need a fix for layout2 with sign out. Make sure the class = "copyrightParag" has quotation marks. Please check other syntax errors. I tried to fix it on my own in the branch experimentaltest1.

mary060196 commented 5 years ago

Hey, Alvin!

Thank you so much for pointing this out. The template 'base.html' is an old template version; the front end team is currently working on other templates that are currently located in cisc3140-su19-project/app/Templates/Base Templates/templates/ I took a quick look, and 'copyParag' has single quotes around its classname inside the templates in that folder - which should be sufficient for the file to recognize it. It also works pretty well when it is run with a python back-end (I checked with a short 'test.py').

Thank you very much for your notification! Your help is so essential for the project's quality! Please tell us if you still notice this issue within the templates. Miriam

AlvinH349 commented 5 years ago

Hi front-end team,

 Thanks for the update on your work. So far, most of your HTML files are looking good. I believe there are a few syntaxes related to the tags like the form tag in base.html. Keep on the good work.

from, Alvin Huang

mary060196 commented 5 years ago

Hello, Alvin!

You are asking a very good question! I've taken a look at the 'base.html' file, and, apparently, there is an extra opening <form> tag without a closing tag. However, a closer look will show that the extra <form> tag is actually located inside a Jinja if statement. Here it is in lines 140-144: `{%- if user %}

{# Here, the user is logged in, so the form works. #} {%- else %} {# The form is inactive since the user is logged out! #} {% endif -%}` This `if` statement tells that exactly one of the scenarios will execute. The closing `
` tag for the one chosen open tag is on line 170: ` {#- Closing the 'trendingForm' from above #}` In other words, when the template is called, there will be exactly one opening form tag and one closing tag, such that this particular element in the 'base.html' will not create an error. Alvin, we are so lucky to have such persistent students in the class like you and the guys from the Back-End team. Please feel free to ask about any aspect that seems suspiciously incorrect. Great thanks! Best regards, Miriam Front End team