DataMedSci / pymchelper

Python toolkit for SHIELD-HIT12A and FLUKA
http://datamedsci.github.io/pymchelper/
15 stars 7 forks source link

plan.py: issue with coordinate systems #609

Closed nbassler closed 1 year ago

nbassler commented 1 year ago

assuming beam traveling along z in positive direction is standard in MC.

Unfortunately it seems that y-axis spot data generated by plan has its y-axis flipped. Unsure about x, and possibly z many be negative, assuming system is always righthanded.

This requires some investigation. I suspect there will be no universal solution, but may require an option for plan to convert to either coordinate system which is needed. Beginning to design MC setups traveling in negative z-direction would create much extra confusion and work...

nbassler commented 1 year ago

related: https://github.com/APTG/2022_DCPT_LET/pull/12#issuecomment-1339104411

grzanka commented 1 year ago

beam along Z direction is a standard for general purpose MC. If you apply MC to simulation of patient plans I assume this is not a standard anymore. When I take look at the PHITS manual for radiotherapy application, the beam source is transformed according to the DICOM plan (see https://phits.jaea.go.jp/rireki-manuale.html).

I can take a look at TOPAS and FLUKA as well.

grzanka commented 1 year ago

It seems beam along negative Z is a popular example:

image

nbassler commented 1 year ago

imagine the wonderful z-axes pymchelper will produce for DDCs.

grzanka commented 1 year ago

What is DDCs ?

wt., 7 mar 2023, 16:25 użytkownik Niels Bassler @.***> napisał:

imagine the wonderful z-axes pymchelper will produce for DDCs.

— Reply to this email directly, view it on GitHub https://github.com/DataMedSci/pymchelper/issues/609#issuecomment-1458363226, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYIPDPHUXJOBDXQPD4BOV3W25HORANCNFSM6AAAAAAVSIUXDQ . You are receiving this because you commented.Message ID: @.***>

nbassler commented 1 year ago

depth dose curves

nbassler commented 1 year ago

after today's discussion with Leszek, we agreed that I will add -xflip -yflip options to plan.py. This should allow full flexibility.

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This issue involves the y-axis spot data generated by the plan, which appears to be flipped in the current implementation. The problem may extend to the x-axis and the z-axis having a negative direction. Investigation is required to identify the cause of these discrepancies, and a solution to convert the coordinate systems may be necessary. Implementing a plan for MC setups traveling in the negative z-direction should be considered with caution, as it may introduce extra confusion and workload.

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This issue reports a problem with the y-axis spot data generated by the plan, which seems to have its y-axis flipped. Additionally, there might be issues with the x and z-axes. The user suggests investigating this issue and introducing a conversion option for the plan to adapt to any required coordinate system, as designing MC setups with negative z-direction could create confusion and additional work.