Closed grzanka closed 1 year ago
Reviewpad Report
:bangbang: Errors
Co-authored-by: Łukasz Pitrus 56313631+p1003@users.noreply.github.com' (395f97c6aa7d887f0b60ab939cc9ae3105867720)
AI-Generated Pull Request Summary: This pull request introduces the following changes to the codebase:
pymchelper/readers/shieldhit/general.py
, some changes and improvements are made:
TypeVar
and define PathLike
type hint for both strings and Path objectsfile_has_sh_magic_number
and extract_sh_ver
functions to use PathLike
type hint and make some checks on the file pathspymchelper/readers/shieldhit/reader_bdo2019.py
, update a few logging statementspymchelper/writers/hdf.py
, introduce changes to make the code compatible with multiple pages:
write
function to handle multiple pages and create corresponding datasets in the HDF5 filetests/test_hdf.py
which tests HDF conversion function with multiple pagestests/res/shieldhit/v1.0.0
directory for testing.Overall, these updates improve the functionality of the code, making it better suited for handling files with multiple pages and paths of different types.
Add multipage support to HDF converter