Naming update for json convertion

DataMedSci / pymchelper

Python toolkit for SHIELD-HIT12A and FLUKA

http://datamedsci.github.io/pymchelper/

15 stars 7 forks source link

Naming update for json convertion #631

Closed p1003 closed 1 year ago

p1003 commented 1 year ago

PR is conducted by problems on UI with proper naming convertion

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request updates the naming of axis properties in the JSON writer and corresponding tests. It changes the key format from {i+1}_axis to axis_dim{i+1} for better clarity and consistency.

reviewpad[bot] commented 1 year ago

Reviewpad Report

:warning: Warnings

Please link an issue to the pull request

:bangbang: Errors

Unconventional commit detected: 'naming update' (3cecf92c6e2ae28ff380bb18f7bdc8736f4def06)
Unconventional title detected: 'Naming update for json convertion' illegal 'N' character in commit message type: col=00

reviewpad[bot] commented 1 year ago

📈 Pull Request Metrics

💻 Coding Time: 1 minute 🛻 Pickup Time: 23 hours 👀 Review Time: 5 seconds